aboutsummaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2018-05-01Remove blockmaxsize option from init.cppfanquake
2018-04-26Default to defining endian-conversion DECLs in compat w/o configMatt Corallo
While this isn't a supported build configuration, some build systems need to build without going through our autotools steps, so defaulting to something sane may make it easier to build. Specifically, this fixes the inability to build rust-bitcoinconsensus on some non-x86 platforms. It needs to build without our autotools/configure steps to ensure correct compile args are passed from the rust build system to gcc. Converting the args from the rust build system to gcc would be a lot of unmaintainable work. GitHub-Pull: #12998 Rebased-From: 150b2f0
2018-04-26qt:Show the entire Window when double clicking on taskbarChun Kuan Lee
GitHub-Pull: #12999 Rebased-From: 67bf2aa
2018-04-26depends: Fix Qt build with XCode 9.3fanquake
GitHub-Pull: #12946 Rebased-From: 5b4fc3e
2018-04-26Avoid launching as admin when NSIS installer ends.JeremyRand
The Bitcoin Core NSIS script runs with elevated privileges. Unfortunately, this means that it launches Bitcoin Core itself with elevated privileges when the user chooses to launch Bitcoin Core at the end of the installation procedure. This commit works around the issue by having explorer.exe launch Bitcoin Core. Seems to be a similar approach to what http://nsis.sourceforge.net/ShellExecAsUser_plug-in does, but without a plugin. h/t to "UK" at https://mdb-blog.blogspot.se/2013/01/nsis-lunch-program-as-user-from-uac.html?showComment=1410158039989#c2463780017054126736 for the sample code. Fixes #7990. GitHub-Pull: #12985 Rebased-From: 7d8a8cc
2018-04-26[config] Remove blockmaxsize optionJohn Newbery
The blockmaxsize option was marked as deprecated in V0.15.1, and code was added to convert provided blockmaxsize into blockmaxweight. However, this code was incorrectly implemented, and blockmaxsize was silently ignored. No users have complained about blockmaxsize being ignored, so just remove it in V0.17. GitHub-Pull: #12756 Rebased-From: 4757c04
2018-04-26Fix illegal default `addProxy` and `addrSeparateProxyTor` settings.251
GitHub-Pull: #12650 Rebased-From: 40c5886
2018-04-26Limit the number of IPs we use from each DNS seedere0
A risk exists where a malicious DNS seeder eclipses a node by returning an enormous number of IP addresses. In this commit we mitigate this risk by limiting the number of IP addresses addrman learns to 256 per DNS seeder. GitHub-Pull: #12626 Rebased-From: 46e7f80
2018-04-24Merge #13049: [0.16] qa: BackportsMarcoFalke
41c29f6d1d qa: Fix python TypeError in script.py (MarcoFalke) 7460945e0b [qa] Delete cookie file before starting node (Suhas Daftuar) 0a76ed232a qa: Cache only chain and wallet for regtest datadir (MarcoFalke) 6c26df06ad [qa] Ensure bitcoind processes are cleaned up when tests end (Suhas Daftuar) df38b130d9 [tests] Test starting bitcoind with -h and -version (John Newbery) 4bdb0ce517 [tests] Fix intermittent rpc_net.py failure. (John Newbery) 0e98f96e42 test: Use wait_until in tests where time was used for polling (Ben Woosley) 1286f3e49a test: Use wait_until to ensure ping goes out (Ben Woosley) cfebd400ef [test] Round target fee to 8 decimals in assert_fee_amount (Karl-Johan Alm) Pull request description: Similar to #12967 this contains all relevant bugfixes and improvements to the functional test suite. I didn't include fixes to make the tests run on Windows, since that is still an ongoing effort and doesn't seem worth to backport. As all of these are clean cherry-picks, I suggest reviewers redo the cherry-picks to get the same branch and then run the extended test suite. Tree-SHA512: 70e1bc28d5572f93796f1ac4d97d77e8146869c15dcc1e3b65a730fa2641283050f769cefd9791d800c758e0a92f11fd55ed0797ccec87b897c7e701d0187f34
2018-04-20qa: Fix python TypeError in script.pyMarcoFalke
Github-Pull: #12475 Rebased-From: fa41d68a2e3f2148c3539a11b61ff835e3141c0d
2018-04-20[qa] Delete cookie file before starting nodeSuhas Daftuar
If a cookie file exists in a datadir prior to node startup, it must have been leftover from a prior unclean shutdown. As bitcoind will overwrite it anyway, delete it before starting up to prevent the test framework from inadvertently trying to connect using stale credentials. Github-Pull: #12902 Rebased-From: 75d0e4c5444249f0cf81ed0494e2c2717170b695
2018-04-20qa: Cache only chain and wallet for regtest datadirMarcoFalke
Github-Pull: #12638 Rebased-From: fa2310572f4cfcd3322409ce7e37dde155fc4bc9
2018-04-20[qa] Ensure bitcoind processes are cleaned up when tests endSuhas Daftuar
Github-Pull: #12904 Rebased-From: e36a0c08529bccc695ec71a7ec1df89367cc1628
2018-04-20[tests] Test starting bitcoind with -h and -versionJohn Newbery
Github-Pull: #12843 Rebased-From: 63048ec73d790ecbcfe3186f2520dac4460f56e3
2018-04-20[tests] Fix intermittent rpc_net.py failure.John Newbery
rpc_net.py would intermittently fail on Travis, probably due to assuming that two consecutive RPC calls were atomic. Fix this by only testing that amounts are bounded above and below rather than equal. Github-Pull: #12804 Rebased-From: 5a67c0524e5dc98d0e387f189545bc99863916d4
2018-04-20test: Use wait_until in tests where time was used for pollingBen Woosley
Github-Pull: #12553 Rebased-From: 81b0822772169cb697b5994f49398e619d61a12d
2018-04-20test: Use wait_until to ensure ping goes outBen Woosley
Intermittent failure evident here: https://travis-ci.org/bitcoin/bitcoin/jobs/344021180 Github-Pull: #12545 Rebased-From: 0eb84f30d80847b7392ad42b2d916eaf5923a63c
2018-04-20[test] Round target fee to 8 decimals in assert_fee_amountKarl-Johan Alm
The output would produce arbitrary number of decimal points, sometimes resulting in 9 decimals: AssertionError: Fee of 0.00000415 BTC too low! (Should be 0.000006175 BTC) The above looks like the expected fee is 6175 sats when in reality it's 618. Github-Pull: #12486 Rebased-From: 42e1b5d9797b65d3ce13a7cbace15fbedbcd4018
2018-03-14Merge #12636: backport: #11995 Fix Qt build with Xcode 9Wladimir J. van der Laan
f3b8d85 devtools: Exclude patches from lint-whitespace GitHub-Pull: #12442 Rebased-From: fafbf7f (MarcoFalke) 686cb86 [Depends] Fix Qt build with Xcode 9.2 (fanquake) Pull request description: GitHub-Pull: #11995 Rebased-From: 2b1f794 Tree-SHA512: 73d1c0a87fd135f3ad8bb737b97037ef047e582c41a7473833e82776957caf372fcd0caa764fc4eed792e9998e214ae829bad5535db6d589827085a74b0fa6f4
2018-03-14devtools: Exclude patches from lint-whitespaceMarcoFalke
GitHub-Pull: #12442 Rebased-From: fafbf7f
2018-03-13Merge #12648: [0.16] test: Update trusted git rootWladimir J. van der Laan
faf316a43 test: Update trust git root (Wladimir J. van der Laan) Pull request description: Marco Falke's old key expired, causing a travis error while verifying commits 36afd4db4442c45d4078b1a7ad16a1872b5bee0d and before: gpg: Good signature from "Marco Falke <marco.falke@tum.de>" [unknown] gpg: aka "Marco Falke <falke.marco@gmail.com>" [unknown] gpg: Note: This key has expired! Primary key fingerprint: B8B3 F1C0 E58C 15DB 6A81 D30C 3648 A882 F431 6B9B Subkey fingerprint: FE09 B823 E6D8 3A3B C798 3EAA 2D7F 2372 E50F E137 Update the trusted root commit to the commit after that, to fix this issue. (cherry picked from commit 7deba93bdc76616011a9f493cbc203d60084416f) Tree-SHA512: c86cc23d087af54a1448545c122fc67a0c556b5eac8ac7d16eeec8c42d8d0d81b7b5041f9a175787604aa47883b68403cfa01c10a52db64e35be52e559b20ec8
2018-03-12[Depends] Fix Qt build with Xcode 9.2fanquake
GitHub-Pull: #11995 Rebased-From: 2b1f794
2018-03-08test: Update trust git rootWladimir J. van der Laan
Marco Falke's old key expired, causing a travis error while verifying commits 36afd4db4442c45d4078b1a7ad16a1872b5bee0d and before: gpg: Good signature from "Marco Falke <marco.falke@tum.de>" [unknown] gpg: aka "Marco Falke <falke.marco@gmail.com>" [unknown] gpg: Note: This key has expired! Primary key fingerprint: B8B3 F1C0 E58C 15DB 6A81 D30C 3648 A882 F431 6B9B Subkey fingerprint: FE09 B823 E6D8 3A3B C798 3EAA 2D7F 2372 E50F E137 Update the trusted root commit to the commit after that, to fix this issue. (cherry picked from commit 7deba93bdc76616011a9f493cbc203d60084416f)
2018-03-07Merge #12637: backport: #12556 fix version typo in getpeerinfo RPC call helpMarcoFalke
e730b82b07 fix version typo (Tamas Blummer) Pull request description: GitHub-Pull: #12556 Rebased-From: d16bfaa Tree-SHA512: b6626fabdd5f493016334ada0182565c7f834a22dc08dc846c71a190e61193dd4e28754e67b20086d9afeab9a58e38c3621c614eadf368b2d35b9c08a843356a
2018-03-07fix version typoTamas Blummer
GitHub-Pull: #12556 Rebased-From: d16bfaa
2018-03-05Merge #12585: [0.16] depends: Switch to downloading expat from GitHubMarcoFalke
25afebc2ba depends: Switch expat download to GitHub (fanquake) Pull request description: @droark [mentioned](https://github.com/bitcoin/bitcoin/pull/12402#issuecomment-370098383) the expat download was failing when trying to gitian build 0.16. I tried locally and also saw issues: ``` make download Checksum missing or mismatched for expat source. Forcing re-download. Fetching expat-2.2.1.tar.bz2 from https://downloads.sourceforge.net/project/expat/expat/2.2.1 % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 0 0 0 0 0 0 0 0 --:--:-- 0:00:01 --:--:-- 0 100 652 100 652 0 0 361 0 0:00:01 0:00:01 --:--:-- 0 /Users/xxx/Github/bitcoin/depends/work/download/expat-2.2.1/expat-2.2.1.tar.bz2.temp: FAILED shasum: WARNING: 1 computed checksum did NOT match Fetching expat-2.2.1.tar.bz2 from https://bitcoincore.org/depends-sources % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 0 0 0 0 0 0 0 0 --:--:-- 0:00:01 --:--:-- 0 curl: (22) The requested URL returned error: 404 Not Found make[1]: *** [/Users/xxx/Github/bitcoin/depends/sources/download-stamps/.stamp_fetched-expat-expat-2.2.1.tar.bz2.hash] Error 22 make: *** [download-linux] Error 2 ``` This switches to downloading from GitHub, as we are doing in master. Tree-SHA512: 0e3072ce4d8fee3e2bc434afc7469968c21e01ca35aa2ccbffc25f8e9b00af2e4a5f3f9e4cd5c0cd8e72a10b16205236eb0536380849109a739c09358dbc1394
2018-03-03depends: Switch expat download to GitHubfanquake
2018-03-01Merge #12518: [0.16] Bump leveldb subtreeWladimir J. van der Laan
835a21b Squashed 'src/leveldb/' changes from c521b3ac65..64052c76c5 (MarcoFalke) Pull request description: The leveldb bump is the same branch/commit as in #12451 Tree-SHA512: 585a55747c75e990c9fd73399e98e548c01bef8b960c0a99844326de43663d004d2211b4689518f2d3e51cc48a732e9c92082939c356793143db411224fa75fa
2018-02-27qt: Remove faulty and unnecessary en_US translationWladimir J. van der Laan
This faulty translation contained Chinese messages, and as en_US is our source language, having a separate translation for it is pointless, remove it. Tree-SHA512: 8493876926355890aa3b713851ed53d37ffe601280f7e0f45461abfe9671af10dc5c6ce966adb89b663486a46df43b0a36b797da7e1cd719597a7e15914bd4a2
2018-02-27test: Add missing signal.h headerWladimir J. van der Laan
util_tests.cpp needs to include the signal.h header on FreeBSD. Reported by denis2342 on IRC. Github-Pull: #12447 Rebased-From: dd7e42cbb4390788705031ffa0bc893d26f0597e Tree-SHA512: 10ead029bb59f5d69e37b5679c710f22d64051de26e1ec8342eec4e4dec4d76249e16dff78d192972bcb8d139d99c7555a7cb2fe43b2b911103eab6d6f943b79
2018-02-27doc: Clear out release notes post-0.16.0Wladimir J. van der Laan
Moved to: https://github.com/bitcoin/bitcoin/blob/master/doc/release-notes/release-notes-0.16.0.md Tree-SHA512: 6619521357a1baa5df2d4deb9e75784f6f48711a7b5d5120cf02b47a80e242e41dcf34dadfd1b257bbdcd883c7dd216d36fbfff24abcf03c590bbf0f6bbec520
2018-02-23[depends] Allow depends system to support armv7lHenrik Jonsson
Github-Pull: #12474 Rebased-From: ac91ea64c2b1daec8fee0bfde443c18cf87595ae Tree-SHA512: 61020cab59532738bc876fc4591923a5b48fee7c5729419bc42654d714cd6cad685e6482e199a17bb57ea97edcd129a15561939d55fa40661d8f051329942bdb
2018-02-22doc: Remove note about temporary file from release notesv0.16.0Wladimir J. van der Laan
About time, before tagging final. Tree-SHA512: d54d77a501d227183be7b136025e5ac5e883cd140867368aa552aae89680d536f35f7619f58506069b083c7f718506d42f871fb95e2dcb76ab01cd2159c664be
2018-02-16Bump leveldb subtreeMarcoFalke
2018-02-16Squashed 'src/leveldb/' changes from c521b3ac65..64052c76c5MarcoFalke
64052c76c5 Merge #15: Add filename to corruption errors 135ed0fb4e Add filename to corruption errors git-subtree-dir: src/leveldb git-subtree-split: 64052c76c567cff3dad32d1db0ef969d97b5882f
2018-02-15doc: Update release notes from wiki for rc3v0.16.0rc4Wladimir J. van der Laan
Tree-SHA512: ff0f10dc9672771a941a1bcbf098e7b17ced4c34bd47a1394f16ca0e6f5f4e74e3db4960b2f0a1e7f489e7c438104c32da7754304fc3d64ff29947405e680e1f
2018-02-15qt: Pre-rc4 translations updateWladimir J. van der Laan
Tree-SHA512: b209b5d404395c8031d92f332885f3ec8f8d040090b0afe55a8b915192c040494c387060cc8da4dd25bdb06d2633f8d42adae27a83933704cccf31d26ad0717c
2018-02-15Make signrawtransaction accept P2SH-P2WSH redeemscriptsPieter Wuille
Github-Pull: #12427 Rebased-From: 5f605e172baee35421eb20736601befdd8cad796 Tree-SHA512: caf8c4e1806757d705493de30eea4f6a146a334ca6f6c93bc74cda43abda391b8406dd8ed6765fcde8eb86b3fb55689547ab69a30f34fca0d7896ea8c4e1db67
2018-02-15fix possible shutdown assertion with -reindex-shutdownCory Fields
Credit @eklitzke for reproducing. Github-Pull: #12349 Rebased-From: ceaefdd5f362537a1908d0095059e4be788f3dee Tree-SHA512: bdc614d3c3fba23147be9528c581e25bbf1f0c359b525b4a05472ab42484724a8b34c8b3ed151f3ff23e48235e972950f9daa155d9ca3c4a9de6d61bf0591b4b
2018-02-15test: Add unit test for LockDirectoryWladimir J. van der Laan
Add a unit test for LockDirectory, introduced in #11281. Github-Pull: #12422 Rebased-From: 1d4cbd26e4220982f7f2f60e447199d6f62ae254 Tree-SHA512: 8186f4b22c65153e30ec1e0b68be20fd59d34e1fe565d99f3b5a302780125953b867fb14c37144de3fd7baf5751df94bf3901eebbb7b820491ca452706d4e205
2018-02-15util: Fix multiple use of LockDirectoryWladimir J. van der Laan
This commit fixes problems with calling LockDirectory multiple times on the same directory, or from multiple threads. It also fixes the build on OpenBSD. - Wrap the boost::interprocess::file_lock in a std::unique_ptr inside the map that keeps track of per-directory locks. This fixes a build issue with the clang 4.0.0+boost-1.58.0p8 version combo on OpenBSD 6.2, and should have no observable effect otherwise. - Protect the locks map using a mutex. - Make sure that only locks that are successfully acquired are inserted in the map. - Open the lock file for appending only if we know we don't have the lock yet - The `FILE* file = fsbridge::fopen(pathLockFile, "a");` wipes the 'we own this lock' administration, likely because it opens a new fd for the locked file then closes it. Github-Pull: #12422 Rebased-From: fc888bfcacb875c45bc8f9d7ca1357ab70a30490 Tree-SHA512: c8b8942fad9ea9d9e55f8e5e360f7cf3a8b00cd17e6bc5ec5895e1e6ddcbca796e62e82856e82f0562869a624d75ad510e108077461bb47a87b2b52be0aba866
2018-02-15travis: Don't fetch --unshallow when no longer shallow-cloningWladimir J. van der Laan
Tree-SHA512: a1a6d794431de9639dc985bd42f852f4e11cc2090a826c9a5c2f32658246f5a2a634f113b86ae66bf6222fe3180c3c23145bc297082ff9f61d3abbab5ac53341
2018-02-15travis: Full clone for git subtree checkMarcoFalke
Github-Pull: #12388 Tree-SHA512: 8dc7fd5619e60674021ef58f384ddaa2b0d49a88f8babab03697ab19819954f9521de0ede7398661be670ce6339bfea436b10ad916b72f194e18efdb3721c08d
2018-02-15Interrupt loading thread after shutdown requestJoão Barbosa
Github-Pull: #12415 Rebased-From: 2e9406c0c588ddf6f039fd3ff73c978177483869 Tree-SHA512: ad70df9fdcba38bc9eeac4e4e64f7d8607fbe92aefac3579a26939e642112d70ebee81c5a227bb8735bae87f95640061a5ab22b583275c7dd6c3277544bc427b
2018-02-14Fix rescan test failure due to unset g_address_type, g_change_typeRussell Yanofsky
New global variables were introduced in #11403 and not setting them causes: test_bitcoin: wallet/wallet.cpp:4259: CTxDestination GetDestinationForKey(const CPubKey&, OutputType): Assertion `false' failed. unknown location(0): fatal error in "importwallet_rescan": signal: SIGABRT (application abort requested) It's possible to reproduce the failure reliably by running: src/test/test_bitcoin --log_level=test_suite --run_test=wallet_tests/importwallet_rescan Failures happen nondeterministically because boost test framework doesn't run tests in a specified order, and tests that run previously can set the global variables and mask the bug. Github-Pull: #12424 Rebased-From: b7f6002ed5d12b461eb56b768d06f2468cd0c12e Tree-SHA512: 1cc64db3b1d886d793e9d194b318dde3d5f628bde778a50513de4bf54dcfc77152885e72608927e3e490d253350ca0381847539a904cb31862f3a6fceac88dc1
2018-02-12Fix ignoring tx data requests when fPauseSend is set on a peerMatt Corallo
This resolves a bug introduced in 66aa1d58a158991a8014a91335b5bc9c00062f56 where, if when responding to a series of transaction requests in a getdata we hit the send buffer limit and set fPauseSend, we will skip one transaction per call to ProcessGetData. Bug found by Cory Fields (@theuni). Github-Pull: #12392 Rebased-From: c4af7387634765d254d1432746385cf35917d367 Tree-SHA512: d2f7707eb9f925a655f66e5e77ce406c5266f7b2feccd5bcdabf6d5bc27a3f6578e753fac83d9c8c3fd7cf7de6fee086eee2f95f77af99ea2c4e5ae77c322c58
2018-02-12Reset pblocktree before deleting LevelDB fileSjors Provoost
Github-Pull: #12401 Rebased-From: a8b5d20f4f171828b2bd70ab2405c42b1e452e5b Tree-SHA512: 3a87b6113283c3588f46bb5c725ec33ac639e2f91c589b5c0eb4375e3d23bd6c18e7ba96faf70be2afea86d8e6252bf4dbcf9c9ed166ce2d49846ff947a36d2e
2018-02-08doc: Update release notes from wiki (for rc3 PRs)v0.16.0rc3Wladimir J. van der Laan
Tree-SHA512: 34fa3ae23c0857fe7a0972b7c5dee802dc66b1eb85d6f70dc50257c4b61a10bab3d481cae6288d5a5da3230505d12e861373988a16a888a3198fbddd36a919bb
2018-02-08qt: Pre-rc3 translations updateWladimir J. van der Laan
Tree-SHA512: e91c44f19b4a6b18736e664e9f446f3e6b457a1b239999ed0171965cfb2af2702b0083340a789d26c293ebf71e52d4a87af0e44d4e6a83a920bbf98c1c3dffa9
2018-02-08Bech32 addresses in dumpwalletfivepiece
Output bech32 addresses in dumpwallet if address type is not as legacy Github-Pull: #12315 Rebased-From: 45eea40aa88f047111a9b1151fe4d1bad5c560e2 Tree-SHA512: 3426292ddaeaafebc25fe84802011f5569a0cbb47fcc3209e7f00f64fc6eb1e637732722bbd02dce8d46be87d0f3687ce8370e71e9286bf7d00afc0a895faecb
generated by cgit v1.2.3 (git 2.26.2) at 2024-08-19 22:51:11 +0000