Age | Commit message (Collapse) | Author |
|
endpoint for lock-time calculations"
This reverts commit 9d55050773d57c0e12005e524f2e54d9e622c6e2.
As noted by Luke-Jr, under some conditions this will accept transactions which are invalid by the network
rules. This happens when the current block time is head of the median time past and a transaction's
locktime is in the middle.
This could be addressed by changing the rule to MAX(this_block_time, MTP+offset) but this solution and
the particular offset used deserve some consideration.
|
|
lock-time constraints"
This reverts commit dea8d21fc63e9f442299c97010e4740558f4f037.
|
|
Also update transifex slug for new version.
|
|
c939792 Add BIP65 CHECKLOCKTIMEVERIFY to release notes (Peter Todd)
|
|
30d9662 Reject invalid pubkeys when reading ckey items from the wallet. (Gregory Maxwell)
|
|
e9e6163 Make -checkmempool=1 not fail through int32 overflow (Pieter Wuille)
|
|
This makes the behavior more consistent with key objects and will
reject some corrupted pubkeys (e.g. zero length).
|
|
0be387a unittest: fix test for null tx input (Daniel Kraft)
|
|
a83f3c2 Add explicit shared_ptr constructor due to C++11 error (Bob McElrath)
|
|
040c0ea Init: Cleanup error and warning strings (MarcoFalke)
6782f58 [trivial] Latest config.guess (MarcoFalke)
bf68191 [trivial] rpcnet: fix typo (MarcoFalke)
95f4291 [trivial] Rewrite help text for feature enabled by default (MarcoFalke)
|
|
3e187f2 Fix BIP65 p2p test (Suhas Daftuar)
|
|
|
|
Also update doc/translation_strings_policy.md
|
|
|
|
ad5aae1 constify missing catch cases (Philip Kaufmann)
|
|
214de7e [Trivial] ensure minimal header conventions (Philip Kaufmann)
|
|
ab1f560 Support -checkmempool=N, which runs checks on average once every N transactions (Pieter Wuille)
|
|
4252cd0 Update to my new key (Pieter Wuille)
|
|
6e800c2 Add Pieter's new PGP key to verify-commits/trusted-keys (Matt Corallo)
1d94b72 Whitelist commits signed with Pieter's now-revoked key (Matt Corallo)
27252b7 Fix pre-push-hook regexes (Matt Corallo)
|
|
298e040 Fix chainstate serialized_size computation (Pieter Wuille)
|
|
|
|
|
|
|
|
create_coinbase() was being called with the wrong arguments
|
|
Update the unittest that is meant to catch a transaction that is invalid
because it has a null input. The old test failed not because of that
but because it was considered a coinbase with too large script. This is
already checked with a different test, though.
The new test is *not* a coinbase since it has two inputs, but one of
them is null. This really checks the corresponding code path in
CheckTransaction.
|
|
- ensure header namespaces and end comments are correct
- add missing header end comments
- ensure minimal formatting (add newlines etc.)
|
|
- ensure all missing catch cases are constant where possible
|
|
2d8c49d Clean up tx prioritization when conflict mined (Casey Rodarmor)
|
|
0d699fc fix locking issue with new mempool limiting (Jonas Schnelli)
|
|
7bbc7c3 Add option for microsecond precision in debug.log (Suhas Daftuar)
|
|
|
|
17a073a Add RPC test for -maxuploadtarget (Suhas Daftuar)
872fee3 Introduce -maxuploadtarget (Jonas Schnelli)
|
|
e04b0b6 added OS X documentation to doc/init.md (Kevin Cooper)
d4aa54c added org.bitcoin.bitcoind.plist for launchd (OS X) (Kevin Cooper)
|
|
143d173 Use BOOST_CHECK_MESSAGE() rather than BOOST_CHECK() in alerts_tests.cpp and initialize strMiscWarning before calling PartitionCheck()." (Eric Lombrozo)
|
|
|
|
* -maxuploadtarget can be set in MiB
* if <limit> - ( time-left-in-24h-cycle / 600 * MAX_BLOCK_SIZE ) has reach, stop serve blocks older than one week and filtered blocks
* no action if limit has reached, no guarantee that the target will not be surpassed
* add outbound limit informations to rpc getnettotals
|
|
Current master crashes on OSX with an exception: "boost: mutex lock failed in pthread_mutex_lock: Invalid argument"
|
|
dea8d21 Enable policy enforcing GetMedianTimePast as the end point of lock-time constraints (Mark Friedenbach)
9d55050 Add rules--presently disabled--for using GetMedianTimePast as endpoint for lock-time calculations (Mark Friedenbach)
|
|
10e2eae rpc: Add maxmempool and effective min fee to getmempoolinfo (Wladimir J. van der Laan)
|
|
|
|
d80e3cb Support gathering of code coverage data for RPC tests (dexX7)
e3b5e6c Run extended BitcoinJ tests for coverage based on config (dexX7)
45d4ff0 Add config option to enable extended RPC tests for code coverage (dexX7)
8e3a27b Require Python for RPC tests, when using lcov (dexX7)
d425877 Remove coverage and test related files, when cleaning up (dexX7)
4d2a926 Ignore coverage data related and temporary test files (dexX7)
|
|
dca7bd3 doc: Add developer notes about gitignore (Wladimir J. van der Laan)
|
|
ceb2a9c doc: mention BIP65 softfork in bips.md (Wladimir J. van der Laan)
|
|
|
|
initialize strMiscWarning before calling PartitionCheck()."
|
|
|
|
|
|
The RPC tests (via `qa/pull-tester/rpc-tests.py`) are now executed,
when gathering code coverage data, for example with `make cov`.
Generating coverage data requires `lcov`, which can installed with:
sudo apt-get install lcov
To also use the BitcoinJ tests, get the test tool:
TOOL_URL=https://github.com/theuni/bitcoind-comparisontool/raw/master/pull-tests-8c6666f.jar
TOOL_HASH=a865332b3827abcde684ab79f5f43c083b0b6a4c97ff5508c79f29fee24f11cd
wget $TOOL_URL -O ./share/BitcoindComparisonTool.jar
echo "$TOOL_HASH ./share/BitcoindComparisonTool.jar" | shasum --algorithm 256 --check
The coverage data can be generated with:
./autogen.sh
./configure --enable-lcov --with-comparison-tool=./share/BitcoindComparisonTool.jar
make
make cov
Optionally the options `--enable-extended-rpc-tests` and
`--enable-comparison-tool-reorg-tests` may be used to enable more time
consuming tests.
It then runs the tests and generates two HTML reports:
- test_bitcoin.coverage/index.html
- total.coverage/index.html
|
|
The configuration option `--enable-comparison-tool-reorg-tests` may be
used to enable extended tests via BitcoinJ also for coverage testing.
|
|
When using lcov to gather code coverage data, the configuration option
`--enable-extended-rpc-tests` may be used to enable extended RPC tests.
|