| Age | Commit message (Collapse) | Author |
|---|
|
15fa95d Fix some typos (fsb4000)
|
|
|
|
dd34570 doc: Improve windows build instructions using Linux subsystem (Wladimir J. van der Laan)
|
|
c7be56d net: push only raw data into CConnman (Cory Fields)
2ec935d net: add CVectorWriter and CNetMsgMaker (Cory Fields)
b7695c2 net: No need to check individually for disconnection anymore (Cory Fields)
fedea8a net: don't send any messages before handshake or after requested disconnect (Cory Fields)
d74e352 net: Set feelers to disconnect at the end of the version message (Cory Fields)
|
|
This fixes one of the last major layer violations in the networking stack.
The network side is no longer in charge of message serialization, so it is now
decoupled from Bitcoin structures. Only the header is serialized and attached
to the payload.
|
|
CVectorWriter is useful for overwriting or appending an existing byte vector.
CNetMsgMaker is a shortcut for creating messages on-the-fly which are suitable
for pushing to CConnman.
|
|
|
|
2f2625a Removed using namespace std from bitcoin-cli/-tx and added std:: in appropriate places. (Karl-Johan Alm)
|
|
5262a15 tx_valid: re-order inputs to how they are encoded (Daniel Cousens)
|
|
I did a build on a windows 10 laptop and took notes, and tried
to improve the document:
- It's the Linux subsystem for Windows, not the other way around.
- Split out dependencies: general ones, 64-bit, 32-bit. Remove the
reference to `build-unix.md`, easy enough to be self-contained.
- Place 64-bit instructions first. 99% will want these.
- Installation instructions: recommend using `/` for prefix, same as we
do on gitian builds. This will allow copying the files to a usable
(from Windows) place using just `make DESTDIR=...`.
- Remove double spaces / consistent width reformatting.
|
|
appropriate places.
|
|
95f4a03 [qa] Test getblocktemplate default_witness_commitment (Suhas Daftuar)
ad04d1c Always add default_witness_commitment with GBT client support (Pieter Wuille)
|
|
f26da35 Fix copypasted comment. (Pavel Janík)
|
|
e3c4f7e Correct help output for waitfor RPC commands (fanquake)
|
|
|
|
ed998ea qt: Avoid OpenSSL certstore-related memory leak (Wladimir J. van der Laan)
5204598 qt: Avoid shutdownwindow-related memory leak (Wladimir J. van der Laan)
e4f126a qt: Avoid splash-screen related memory leak (Wladimir J. van der Laan)
693384e qt: Prevent thread/memory leak on exiting RPCConsole (Wladimir J. van der Laan)
47db075 qt: Plug many memory leaks (Wladimir J. van der Laan)
|
|
|
|
Also, send reject messages earlier in SendMessages(), so that disconnections are
processed earlier.
These changes combined should ensure that no message is ever sent after
fDisconnect is set.
|
|
This way we're not relying on messages going out after fDisconnect has been
set.
This should not cause any real behavioral changes, though feelers should
arguably disconnect earlier in the process. That can be addressed in a later
functional change.
|
|
d2b88f9 Move orphan-conflict removal from main logic into a callback (Matt Corallo)
97e2802 Erase orphans per-transaction instead of per-block (Matt Corallo)
ec4525c Move orphan processing to ActivateBestChain (Matt Corallo)
|
|
ca8549d Always drop the least preferred HB peer when adding a new one. (Gregory Maxwell)
|
|
This makes the orphan map a part of net-processing logic instead
of main logic.
|
|
1126c85 [qa] Change sync_blocks to pick smarter maxheight (Russell Yanofsky)
|
|
- Correctly manage the X509 and X509_STORE objects lifetime.
|
|
Store a reference to the shutdown window on BitcoinApplication,
so that it will be deleted when exiting the main loop.
|
|
Make splash screen queue its own deletion when it receives the finished
command, instead of relying on WA_DeleteOnClose which doesn't work under
these circumstances.
|
|
Make ownership of the QThread object clear, so that the RPCConsole
can wait for the executor thread to quit before shutdown is called. This
increases overall thread safety, and prevents some objects from leaking
on exit.
|
|
None of these are very serious, and are leaks in objects that are
created at most one time.
In most cases this means properly using the QObject parent hierarchy,
except for BanTablePriv/PeerTablePriv which are not QObject,
so use a std::unique_ptr instead.
|
|
09dc406 Make test constant consistent with consensus.h (BtcDrak)
|
|
69bc8e7 [Doc] Move comments above bash command (Amir Abrams)
|
|
|
|
918b126 fix CreateTransaction error messages (instagibbs)
|
|
f004e67 Minor change to comment above new NODE_WITNESS service flag to keep it consitent with existing comment structure. Helps with readability. (Greg Walker)
|
|
67c6326 Send tip change notification from invalidateblock (Russell Yanofsky)
|
|
a33b169 Do not fully sort all nodes for addr relay (Pieter Wuille)
|
|
4512550 Remove unnecessary calls to CheckFinalTx (Jonas Schnelli)
|
|
2e44893 Move -salvagewallet, -zap(wtx) to where they belong (Jonas Schnelli)
|
|
240189b add testcases for getrawtransaction (John Newbery)
ce2bb23 getrawtransaction should take a bool for verbose (jnewbery)
|
|
consitent with existing comment structure. Helps with readability.
|
|
|
|
|
|
|
|
1260c11 Mention the new network toggle functionality in the tooltip. (Pavel Janík)
|
|
e0a9cb2 bench: Fix subtle counting issue when rescaling iteration count (Wladimir J. van der Laan)
|
|
Make sure that the count is a zero modulo the new mask before
scaling, otherwise the next time until a measure triggers
will take only 1/2 as long as accounted for. This caused
the 'min time' to be potentially off by as much as 100%.
|
|
4231032 [Qt] Clean up and fix coincontrol tree widget handling (Wladimir J. van der Laan)
76af4eb [Qt] fix coincontrol sort issue (Jonas Schnelli)
|
|
When a BIP152 HB-mode peer is in the least preferred position and
disconnects, they will not be by ForNode on the next loop. They
will continue to sit in that position and prevent deactivating
HB mode for peers that are still connected.
There is no reason for them to stay in the list if already gone,
so drop the first element unconditionally if there are too many.
Fixes issue #9163.
|
|
|
|
|
|
|
