aboutsummaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2012-04-26listsinceblock: rpc param blockid -> blockhashfreewil
This is more consistent with the rest of the labeling seen by the user when accessing the rpc commands.
2012-04-23Merge pull request #1140 from jgarzik/sign-compareJeff Garzik
Address many more sign comparison warnings
2012-04-23Change signed->unsigned at 3 code sitesJeff Garzik
This resolves signed/unsigned comparison warnings.
2012-04-23CBlock::WriteToDisk() properly checks ftell(3) for error returnJeff Garzik
Rather than storing ftell(3)'s return value -- a long -- in an unsigned int, we store and check a properly typed temp. Then, assured a non-negative value, we store in nBlockPosRet.
2012-04-23Add casts for unavoidable signed/unsigned comparisonsJeff Garzik
At these code sites, it is preferable to cast rather than change a variable's type.
2012-04-23Test ScriptSigArgsExpected() for error, before accumulating return valueJeff Garzik
2012-04-23SigOp and orphan-tx constants and counts are always unsigned.Jeff Garzik
Fixes several sign-comparison warnings.
2012-04-22Merge pull request #1133 from sipa/abspathPieter Wuille
Make GetDataDir return absolute paths
2012-04-22Prefer 'unsigned int' for loop index variables tested against ::size()Jeff Garzik
C++ STL ::size() generally returns unsigned, which implies that "int idx" style of loop variable will generate a signed-vs-unsigned comparison warning when testing the loop exit condition "idx < blah.size()" Update areas of the bitcoin code where loop variables may be more properly and correctly defined as unsigned.
2012-04-22Make GetDataDir return absolute pathsPieter Wuille
2012-04-21Merge pull request #1124 from sipa/rpcobj3Pieter Wuille
extension of #1103: encapsulate mapCommands in CRPCTable
2012-04-21Merge pull request #1131 from laanwj/2012_04_hexstrPieter Wuille
Integrate @JoelKatz's optimized ToHex (#562) into current HexStr function
2012-04-21Merge pull request #1129 from laanwj/2012_04_opcodesPieter Wuille
Add explicit numeric constant value for all opcodes
2012-04-21Merge pull request #1121 from gavinandresen/scripttestGavin Andresen
Data-driven script evaluation unit tests (rebased to fix compiler warning).
2012-04-21Data-drive script evaluation unit tests.Gavin Andresen
2012-04-21Merge pull request #1126 from drizztbsd/masterPieter Wuille
Fix build with gcc 4.7
2012-04-21Integrate @JoelKatz's optimized ToHex (#562) into current HexStr functionWladimir J. van der Laan
2012-04-21Remove no-longer used UI hints in bitcoin coreWladimir J. van der Laan
The Qt UI has its own associated structures for temporary transaction state / cache.
2012-04-21change type of various bare chars to bool that are only used as bool (and ↵Wladimir J. van der Laan
never serialized)
2012-04-21Add explicit numeric constant value for all opcodesWladimir J. van der Laan
- Easier for debugging (what opcode was 0x... again?) - Clarifies that the opcodes are set in stone in the protocol, and signals that it is impossible to insert opcodes in between.
2012-04-21Expose CRPCTable via bitcoinrpc.h for testingPieter Wuille
2012-04-21Encapsulate mapCommands in class CRPCTablePieter Wuille
2012-04-21Encapsulate RPC command dispatch in an array of CRPCCommand'sJeff Garzik
2012-04-20Merge pull request #1122 from dlitz/unsigned-char-fixWladimir J. van der Laan
Unsigned char fix & fix undefined phexdigits[255]
2012-04-20Add missing includes. (Fix bulding under GCC 4.7)Timothy Redaelli
2012-04-19Merge pull request #959 from rebroad/LoadBlockIndexKillablePieter Wuille
Added ability to respond to signals during Block Loading stage.
2012-04-18Added ability to respond to signals during Block Loading stage.R E Broadley
2012-04-18Fix bugs on 'unsigned char' platforms.Dwayne C. Litzenberger
In ISO C++, the signedness of 'char' is undefined. On some platforms (e.g. ARM), 'char' is an unsigned type, but some of the code relies on 'char' being signed (as it is on x86). This is indicated by compiler warnings like this: bignum.h: In constructor 'CBigNum::CBigNum(char)': bignum.h:81:59: warning: comparison is always true due to limited range of data type [-Wtype-limits] util.cpp: In function 'bool IsHex(const string&)': util.cpp:427:28: warning: comparison is always false due to limited range of data type [-Wtype-limits] In particular, IsHex erroneously returned true regardless of the input characters, as long as the length of the string was a positive multiple of 2. Note: For testing, it's possible using GCC to force char to be unsigned by adding the -funsigned-char parameter to xCXXFLAGS.
2012-04-18Fix phexdigits[255] is undefined.Dwayne C. Litzenberger
2012-04-17Merge pull request #1118 from sipa/addbreaksWladimir J. van der Laan
Add missing breaks in optionmodel's switch case
2012-04-17Add missing breaks in optionmodel's switch casePieter Wuille
2012-04-17Merge pull request #1114 from sipa/lesssyncPieter Wuille
Reduce sync frequency for blkindex.dat
2012-04-17Fix tests after recent refactorsPieter Wuille
2012-04-17Merge remote-tracking branch 'jgarzik/mempool'Pieter Wuille
2012-04-17Merge pull request #1117 from sipa/deadlockfixPieter Wuille
Fix potential deadlock
2012-04-17Merge pull request #1112 from sipa/saneserialPieter Wuille
Further reduce header dependencies
2012-04-17Further reduce header dependenciesPieter Wuille
This commit removes the dependency of serialize.h on PROTOCOL_VERSION, and makes this parameter required instead of implicit. This is much saner, as it makes the places where changing a version number can have an influence obvious.
2012-04-17Move proto version to version.h. Reduce header deps a bit more.Jeff Garzik
2012-04-17Move CWalletDB code to new walletdb module.Jeff Garzik
In addition to standard code separation, this change opens the door to fixing several include inter-dependencies.
2012-04-17Remove headers.hPieter Wuille
2012-04-17Merge pull request #1106 from jgarzik/sign-compareGavin Andresen
Fix many sign-comparison warnings found in bitcoin codebase
2012-04-17Merge pull request #1115 from laanwj/2012_04_cleanupmiscGavin Andresen
Delete unused, unreachable and commented code, add missing initializer
2012-04-17Fix potential deadlockPieter Wuille
Conflict: * cs_main in ProcessMessages() (before calling ProcessMessages) * cs_vSend in CNode::BeginMessage versus: * cs_vSend in ThreadMessageHandler2 (before calling SendMessages) * cs_main in SendMessages Even though cs_vSend is a try_lock, if it succeeds simultaneously with the locking of cs_main in ProcessMessages(), it could cause a deadlock.
2012-04-17main.cpp: replace tabs with spacesJeff Garzik
Sometimes they sneak in through the 'vi' door
2012-04-17AlreadyHave(): only hold lock during mapTransactions accessJeff Garzik
2012-04-17Remove unused and unreachable codeWladimir J. van der Laan
2012-04-17Add forgotten initializerWladimir J. van der Laan
2012-04-17Reduce sync frequency for blkindex.datPieter Wuille
Since auto-remove-db-logs was enabled, each time a CTxDB was closed outside of the initial download window, it causes a checkpoint + log cleanup. This is overkill, so reduce the sync frequency to once per minute at most.
2012-04-17Merge pull request #1094 from jgarzik/already-have-lockingJeff Garzik
Locking fix for AlreadyHave()
2012-04-17Bump PROTOCOL_VERSION to 60001, thereby enabling BIP31Jeff Garzik