Age | Commit message (Collapse) | Author |
|
- the call to CloseSocket() is placed after the WSAGetLastError(), because
a CloseSocket() can trigger an error also, which we don't want for the
logging in this two cases
|
|
43f510d Convert closesocket 'compat wrapper' to function in netbase (Wladimir J. van der Laan)
|
|
b069750 Break up CAddrMan's IMPLEMENT_SERIALIZE (Pieter Wuille)
|
|
Simpler alternative to #4348.
The current setup with closesocket() is strange. It poses
as a compatibility wrapper but adds functionality.
Rename it and make it a documented utility function in netbase.
Code movement only, zero effect on the functionality.
|
|
7de3f1c fix help message for RPC getpeerinfo (Philip Kaufmann)
|
|
|
|
43005cf Fix semantic typo in state.CorruptionPossible check (kazcw)
|
|
33357b2 qt: Start core thread only when needed (Wladimir J. van der Laan)
c715ff5 ui: Replace some LogPrintfs with qDebug() (Wladimir J. van der Laan)
96ff9d6 Can't log to debug log before chain params initialized (Wladimir J. van der Laan)
|
|
09c744c Make sure CAutoFile for fees estimate goes out of scope (Pieter Wuille)
|
|
|
|
|
|
c4a321f Add peerid to getpeerinfo to allow correlation with the logs. (Gregory Maxwell)
|
|
Set -discover=0 in regtest framework
|
|
Start the core thread only when needed for initialization
or shutdown.
Avoids a bit of overhead, and also avoids spamming two
log messages before logging is properly initialized.
|
|
This seems to have been missed in 3764.
|
|
These are relatively unimportant messages, so don't need to be logged
without -debug=ui.
|
|
Add a function `AreBaseParamsConfigured` and use this to check
before writing to the debug log. This avoids assertions when the
application happens to log too early, which happens in the GUI.
Messages logged before the base parameters are configured can be
shown using `-printtoconsole`.
|
|
d4d3fbd Do not flush the cache after every block outside of IBD (Pieter Wuille)
|
|
bc42503 Use unordered_map for CCoinsViewCache with salted hash (Pieter Wuille)
|
|
state.Invalid() is always false, check should be IsInvalid()
Broken since 942b33a
|
|
|
|
The option is only effective for either wallet-less builds or if
-disablewallet is specified as well.
Rebased-By: Wladimir J. van der Laan <laanwj@gmail.com>
Rebased-From: 34d5fc0 4e1a196 bd4307b d53a33b 7e09b36
Github-Pull: #4286
|
|
d512534 Fixed error in 'getbalance' when using watchonly addresses. (JaSK)
|
|
|
|
4eedf4f make RandAddSeed() use OPENSSL_cleanse() (Philip Kaufmann)
6354935 move rand functions from util to new random.h/.cpp (Philip Kaufmann)
001a53d add GetRandBytes() as wrapper for RAND_bytes() (Philip Kaufmann)
|
|
49d5712 qt: Ignore showNormalIfMinimized in initialization or shutdown (Wladimir J. van der Laan)
|
|
6265ecc Clarify that redeemScript is often optional (Zak Wilcox)
|
|
76fd7b8 [Qt] Fix segfault when launched with -disablewallet (Cozz Lovan)
|
|
Also get rid of ui_interface flag NOSHOWGUI. It's up to the GUI to
decide this.
Fixes #4360.
|
|
dc942e6 Introduce whitelisted peers. (Pieter Wuille)
|
|
39cc492 Fix Watchonly: cs_main lock not held (Cozz Lovan)
|
|
b45a6e8 Add test for getblocktemplate longpolling (Wladimir J. van der Laan)
ff6a7af getblocktemplate: longpolling support (Luke Dashjr)
|
|
6b407e4 -datadir is now allowed in config files (Zak Wilcox)
|
|
e3496da [Qt] Fix No such slot UnitDisplayStatusBarControl::onDisplayUnitsClicked (Cozz Lovan)
|
|
The regtest framework is local, so often there is no need to
discover our external IP. Setting -discover=0 in util.py works
around shutdown hang caused by GetExternalIP waiting in recv().
|
|
|
|
|
|
|
|
a7e1d50 In -? output: -keypool, -gen, -genproclimit depend on ENABLE_WALLET (Zak Wilcox)
|
|
cd01a5e Enable paranoid corruption checks in LevelDB >= 1.16 (Pieter Wuille)
|
|
|
|
|
|
|
|
|
|
6c37f7f `getrawchangeaddress` should fail when keypool exhausted (Wladimir J. van der Laan)
|
|
An user on IRC reported an issue where `getrawchangeaddress`
keeps returning a single address when the keypool is exhausted.
In my opinion this is strange behaviour.
- Change CReserveKey to fail when running out of keys in the keypool.
- Make `getrawchangeaddress` return RPC_WALLET_KEYPOOL_RAN_OUT when
unable to create an address.
- Add a Python RPC test for checking the keypool behaviour in combination
with encrypted wallets.
|
|
b60be6b Clean up RPCs that are disabled in safe-mode. (Gregory Maxwell)
|
|
|
|
|
|
954d2e7 Avoid a segfault on getblock if it can't read a block from disk. (Ruben Dario Ponticelli)
|