diff options
| author | fanquake <fanquake@gmail.com> | 2021-10-21 08:11:24 +0800 |
|---|---|---|
| committer | fanquake <fanquake@gmail.com> | 2021-10-21 08:35:30 +0800 |
| commit | 69986de383ffea500e2e22975f97f96427941724 (patch) | |
| tree | aa0cc8b4d82e2fb33fa836c1031876bee4c85659 /test | |
| parent | c8bae2be341c921823eee95a9eec7e2b74f2f0ae (diff) | |
| parent | b65a25a84666d41a0af4ad98ffadfa4ac802d1bb (diff) | |
Merge bitcoin/bitcoin#22839: log: improve addrman logging
b65a25a84666d41a0af4ad98ffadfa4ac802d1bb log: improve addrman logging (Martin Zumsande)
Pull request description:
The addrman helper functions `GetNewBucket()` and `GetTriedBucket()`
1) log into the wrong category (`BCLog::NET` instead of `BCLog::ADDRMAN`)
2) log too unspecifically - especially `GetTriedBucket()` gets called from many different places (e.g. `Check_()`, `Serialize()`), it seems sufficient to me logging these when moving an address from new to tried. Running a node with `-checkaddrman=1`and net logging currently results in a lot of repetitive log entries.
This PR moves these log entries to `Add_()` and `Good_()` and also adds logging for `Select_()` (allowing statistics about New/Tried success probabilities), `GetAddr_()`, `ClearNew()` and `MakeTried()`.
ACKs for top commit:
jnewbery:
ACK b65a25a84666d41a0af4ad98ffadfa4ac802d1bb
vasild:
ACK b65a25a84666d41a0af4ad98ffadfa4ac802d1bb
Tree-SHA512: 90ab0f64eb44b7388a198efccb613577b74989fea73194bda7de8bfbd50bdb19127cb12f5ec645c7859afdb89290614a79e255f3af0a63a58d4f21aa8fe7b696
Diffstat (limited to 'test')
| -rwxr-xr-x | test/functional/p2p_invalid_messages.py | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/test/functional/p2p_invalid_messages.py b/test/functional/p2p_invalid_messages.py index f3b80abb59..82c7e94c59 100755 --- a/test/functional/p2p_invalid_messages.py +++ b/test/functional/p2p_invalid_messages.py @@ -209,7 +209,7 @@ class InvalidMessagesTest(BitcoinTestFramework): self.test_addrv2('unrecognized network', [ 'received: addrv2 (25 bytes)', - 'IP 9.9.9.9 mapped', + '9.9.9.9:8333 mapped', 'Added 1 addresses', ], bytes.fromhex( |