diff options
| author | MarcoFalke <falke.marco@gmail.com> | 2021-12-16 08:54:59 +0100 |
|---|---|---|
| committer | MarcoFalke <falke.marco@gmail.com> | 2021-12-16 08:55:06 +0100 |
| commit | df6e961c417bc6e733f2fcefd2d712178a3da4b6 (patch) | |
| tree | fb8f9fe31554403a1f59c3170791887a06ba4c95 /test | |
| parent | ce463cf450539867f3d48fe70f64b78051c32add (diff) | |
| parent | e4a8d561edf3cfb326e86c87155fed41a61e7333 (diff) | |
Merge bitcoin/bitcoin#23777: doc: follow-ups from #23365 (index backwards search)
e4a8d561edf3cfb326e86c87155fed41a61e7333 doc: add explanations for assert in index and magic numbers in test (Martin Zumsande)
Pull request description:
This adds two explanations suggested in the review of #23365, that I didn't manage to address before that PR was merged:
https://github.com/bitcoin/bitcoin/pull/23365#discussion_r763981042
https://github.com/bitcoin/bitcoin/pull/23365#discussion_r763982639
ACKs for top commit:
jnewbery:
ACK e4a8d561edf3cfb326e86c87155fed41a61e7333
Tree-SHA512: 0500c8abb37bb3e3694463ad5e74b2e1483615ccf1d7529b0d5faa694652ada17d242dc7fda6d995733766c627d54178a2c8fa21a570cdf13292f64ff5425b56
Diffstat (limited to 'test')
| -rwxr-xr-x | test/functional/feature_blockfilterindex_prune.py | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/test/functional/feature_blockfilterindex_prune.py b/test/functional/feature_blockfilterindex_prune.py index 83a50c504e..2451988135 100755 --- a/test/functional/feature_blockfilterindex_prune.py +++ b/test/functional/feature_blockfilterindex_prune.py @@ -29,6 +29,8 @@ class FeatureBlockfilterindexPruneTest(BitcoinTestFramework): self.log.info("prune some blocks") pruneheight = self.nodes[0].pruneblockchain(400) + # the prune heights used here and below are magic numbers that are determined by the + # thresholds at which block files wrap, so they depend on disk serialization and default block file size. assert_equal(pruneheight, 248) self.log.info("check if we can access the tips blockfilter when we have pruned some blocks") |