diff options
author | MarcoFalke <falke.marco@gmail.com> | 2020-12-04 15:18:44 +0100 |
---|---|---|
committer | MarcoFalke <falke.marco@gmail.com> | 2020-12-04 15:18:48 +0100 |
commit | c1604483d34f745fe6dc77a5f1be4fcfad7408a7 (patch) | |
tree | 916aee1f4fb0b787ecb52c9f16ab07f810ca01b7 /test | |
parent | 9601c0d7aab771d3bfbab1cf7b988ee4ccf5132c (diff) | |
parent | fac7ab1d5b58fb9cfd80d5cf74ac4d2e5cb8eff2 (diff) | |
download | bitcoin-c1604483d34f745fe6dc77a5f1be4fcfad7408a7.tar.xz |
Merge #20566: refactor: Use C++17 std::array where possible
fac7ab1d5b58fb9cfd80d5cf74ac4d2e5cb8eff2 refactor: Use C++17 std::array where possible (MarcoFalke)
Pull request description:
Using the C++11 std::array with explicit template parameters is problematic because overshooting the size will fill the memory with default constructed types.
For example,
```cpp
#include <array>
#include <iostream>
int main()
{
std::array<int, 3> a{1, 2};
for (const auto& i : a) {
std::cout << i << std::endl; // prints "1 2 0"
}
}
```
ACKs for top commit:
jonasschnelli:
Code Review ACK fac7ab1d5b58fb9cfd80d5cf74ac4d2e5cb8eff2
practicalswift:
cr ACK fac7ab1d5b58fb9cfd80d5cf74ac4d2e5cb8eff2
vasild:
ACK fac7ab1d
promag:
Code review ACK fac7ab1d5b58fb9cfd80d5cf74ac4d2e5cb8eff2.
Tree-SHA512: ef7e872340226e0d6160e6fd66c6ca78b2ef9c245fa0ab27fe4777aac9fba8d5aaa154da3d27b65dec39a6a63d07f1063c3a8ffb667a98ab137756a1a0af2656
Diffstat (limited to 'test')
0 files changed, 0 insertions, 0 deletions