diff options
| author | MacroFake <falke.marco@gmail.com> | 2022-07-14 09:55:40 +0200 |
|---|---|---|
| committer | MacroFake <falke.marco@gmail.com> | 2022-07-14 09:55:44 +0200 |
| commit | 8efa73e7ce4ea0c1b7ad5c3947a5ecf9fb6361d3 (patch) | |
| tree | 615e567005796fbb64b7ef2e3fe9255b97daa726 /test | |
| parent | 31c6309cc60ae3fee2d3ecc2aff9576596fb98ac (diff) | |
| parent | 613e2211493ae2c78b71d1f4ea62661438d2cb73 (diff) | |
| download | bitcoin-8efa73e7ce4ea0c1b7ad5c3947a5ecf9fb6361d3.tar.xz | |
Merge bitcoin/bitcoin#25557: p2p: Eliminate atomic for m_last_getheaders_timestamp
613e2211493ae2c78b71d1f4ea62661438d2cb73 test: remove unnecessary parens (Suhas Daftuar)
e939cf2b7645c2b20a68cb6129f3aebfdf287d61 Remove atomic for m_last_getheaders_timestamp (Suhas Daftuar)
Pull request description:
Eliminate the unnecessary atomic guarding `m_last_getheaders_timestamp`, which is only accessed in a single thread (thanks to MarcoFalke for pointing this out).
Also address a nit that came up in #25454.
ACKs for top commit:
MarcoFalke:
review ACK 613e2211493ae2c78b71d1f4ea62661438d2cb73
vasild:
ACK 613e2211493ae2c78b71d1f4ea62661438d2cb73
Tree-SHA512: 6d6c473735b450b8ad43aae5cf16ed419154d72f4a05c0a6ce6f26caecab9db2361041398b70bf9395611c107d50897f501fa5fdbabb2891144bbc2b479dfdad
Diffstat (limited to 'test')
| -rwxr-xr-x | test/functional/feature_minchainwork.py | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/test/functional/feature_minchainwork.py b/test/functional/feature_minchainwork.py index 9d0ad5ef9d..fb4024b1b0 100755 --- a/test/functional/feature_minchainwork.py +++ b/test/functional/feature_minchainwork.py @@ -82,7 +82,7 @@ class MinimumChainWorkTest(BitcoinTestFramework): msg.hashstop = 0 peer.send_and_ping(msg) time.sleep(5) - assert ("headers" not in peer.last_message or len(peer.last_message["headers"].headers) == 0) + assert "headers" not in peer.last_message or len(peer.last_message["headers"].headers) == 0 self.log.info("Generating one more block") self.generate(self.nodes[0], 1) |