diff options
| author | MacroFake <falke.marco@gmail.com> | 2022-09-15 08:45:04 +0200 |
|---|---|---|
| committer | MacroFake <falke.marco@gmail.com> | 2022-09-15 08:45:08 +0200 |
| commit | 718304d222671f98d2335cd9b90a3022f62d7b21 (patch) | |
| tree | 6be1e2ee64b9744945c6d4db175cf6da3dc13215 /test | |
| parent | 2e3cd26a1a5e071407b79cf02c35f6cf42aa6191 (diff) | |
| parent | 6f8e3818af7585b961039bf0c768be2e4ee44e0f (diff) | |
| download | bitcoin-718304d222671f98d2335cd9b90a3022f62d7b21.tar.xz | |
Merge bitcoin/bitcoin#26084: sendall: check if the maxtxfee has been exceeded
6f8e3818af7585b961039bf0c768be2e4ee44e0f sendall: check if the maxtxfee has been exceeded (ishaanam)
Pull request description:
Previously the `sendall` RPC didn't check whether the fees of the transaction it creates exceed the set `maxtxfee`. This PR adds this check to `sendall` and a test case for it.
ACKs for top commit:
achow101:
ACK 6f8e3818af7585b961039bf0c768be2e4ee44e0f
Xekyo:
ACK 6f8e3818af7585b961039bf0c768be2e4ee44e0f
glozow:
Concept ACK 6f8e3818af7585b961039bf0c768be2e4ee44e0f. The high feerate is unlikely but sendall should respect the existing wallet options.
Tree-SHA512: 6ef0961937091293d49be16f17e4451cff3159d901c0c7c6e508883999dfe0c20ed4d7126bf74bfea8150d4c1eef961a45f0c28ef64562e6cb817fede2319f1a
Diffstat (limited to 'test')
| -rwxr-xr-x | test/functional/wallet_sendall.py | 15 |
1 files changed, 15 insertions, 0 deletions
diff --git a/test/functional/wallet_sendall.py b/test/functional/wallet_sendall.py index aa8d2a9d2c..f24329f7b3 100755 --- a/test/functional/wallet_sendall.py +++ b/test/functional/wallet_sendall.py @@ -264,6 +264,18 @@ class SendallTest(BitcoinTestFramework): recipients=[self.remainder_target], options={"inputs": [utxo], "send_max": True}) + @cleanup + def sendall_fails_on_high_fee(self): + self.log.info("Test sendall fails if the transaction fee exceeds the maxtxfee") + self.add_utxos([21]) + + assert_raises_rpc_error( + -4, + "Fee exceeds maximum configured by user", + self.wallet.sendall, + recipients=[self.remainder_target], + fee_rate=100000) + def run_test(self): self.nodes[0].createwallet("activewallet") self.wallet = self.nodes[0].get_wallet_rpc("activewallet") @@ -312,5 +324,8 @@ class SendallTest(BitcoinTestFramework): # Sendall fails when using send_max while specifying inputs self.sendall_fails_on_specific_inputs_with_send_max() + # Sendall fails when providing a fee that is too high + self.sendall_fails_on_high_fee() + if __name__ == '__main__': SendallTest().main() |