diff options
| author | W. J. van der Laan <laanwj@protonmail.com> | 2021-11-25 11:39:44 +0100 |
|---|---|---|
| committer | W. J. van der Laan <laanwj@protonmail.com> | 2021-11-25 11:39:54 +0100 |
| commit | 791dd1f41ed787516169a33a590ca42b53f8b8fb (patch) | |
| tree | 5d19822753a85f818c504e889b86600d3bd230e8 /test | |
| parent | 9facad0da65815211e166870c7c9fb24e9b921ac (diff) | |
| parent | fa186eb7f45a9d420503f96ff3a5f753afb75dec (diff) | |
| download | bitcoin-791dd1f41ed787516169a33a590ca42b53f8b8fb.tar.xz | |
Merge bitcoin/bitcoin#23538: Remove strtol in torcontrol
fa186eb7f45a9d420503f96ff3a5f753afb75dec Remove strtol in torcontrol (MarcoFalke)
Pull request description:
The sequence of octal chars is fully validated before calling `strtol`, so it can be replaced by a simple loop. This removes the last "locale depended" `strtol` call. Also, removes some unused includes.
ACKs for top commit:
laanwj:
Code review and tested ACK fa186eb7f45a9d420503f96ff3a5f753afb75dec
Tree-SHA512: aafa4c68046e5ec48824c4f2c18e4920e5fe1d1fa03a8a297b2f40d0a1967cd0dad3554352519073a1620714e958ed5133cbc6b70bedcc508a423551d829f80e
Diffstat (limited to 'test')
| -rwxr-xr-x | test/lint/lint-locale-dependence.sh | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/test/lint/lint-locale-dependence.sh b/test/lint/lint-locale-dependence.sh index b58600e6cb..661bc35175 100755 --- a/test/lint/lint-locale-dependence.sh +++ b/test/lint/lint-locale-dependence.sh @@ -37,15 +37,12 @@ export LC_ALL=C # See https://doc.qt.io/qt-5/qcoreapplication.html#locale-settings and # https://stackoverflow.com/a/34878283 for more details. -# TODO: Reduce KNOWN_VIOLATIONS by replacing uses of locale dependent stoul/strtol with locale -# independent ToIntegral<T>(...) or the ParseInt*() functions. # TODO: Reduce KNOWN_VIOLATIONS by replacing uses of locale dependent snprintf with strprintf. KNOWN_VIOLATIONS=( "src/dbwrapper.cpp:.*vsnprintf" "src/test/dbwrapper_tests.cpp:.*snprintf" "src/test/fuzz/locale.cpp" "src/test/fuzz/string.cpp" - "src/torcontrol.cpp:.*strtol" ) REGEXP_IGNORE_EXTERNAL_DEPENDENCIES="^src/(crypto/ctaes/|leveldb/|secp256k1/|minisketch/|tinyformat.h|univalue/)" |