diff options
| author | Wladimir J. van der Laan <laanwj@protonmail.com> | 2020-11-19 10:12:52 +0100 |
|---|---|---|
| committer | Wladimir J. van der Laan <laanwj@protonmail.com> | 2020-11-19 10:40:46 +0100 |
| commit | cddcd22ab326428b461f1937f1db4d1329e46faf (patch) | |
| tree | bc83f77a74a6f561cde6a0fc7de7a3147c5e1776 /test | |
| parent | ea7926527ce36c05cacb99602b2b59579ff646e8 (diff) | |
| parent | 961f148cb1b4caab86b4354357999e03433b04b1 (diff) | |
| download | bitcoin-cddcd22ab326428b461f1937f1db4d1329e46faf.tar.xz | |
Merge #20288: script, doc: contrib/seeds updates
961f148cb1b4caab86b4354357999e03433b04b1 doc: update contrib/seeds/README dnspython installation info (Jon Atack)
dd7b5f46d85401254630abf6976f59b5b8eed181 script: fix deprecation warning in makeseeds.py (Jon Atack)
Pull request description:
Seen while reviewing #20237.
1. Fix a deprecation warning in `contrib/seeds/makeseeds.py`
```
makeseeds.py:139: DeprecationWarning: please use dns.resolver.resolve() instead
asn = int([x.to_text() for x in dns.resolver.query('.'.join(
```
- Per https://dnspython.readthedocs.io/en/latest/whatsnew.html, `dns.resolver.query()` was deprecated in `dnspython` version 2.0.0.
- See https://dnspython.readthedocs.io/en/latest/resolver-class.html for more info on the resolver class.
2. Update the `dnspython` dependency installation instructions in `contrib/seeds/README`
- The markdown rendering can be seen here: https://github.com/jonatack/bitcoin/tree/contrib-seeds-fixups/contrib/seeds
ACKs for top commit:
laanwj:
code review ACK 961f148cb1b4caab86b4354357999e03433b04b1
Tree-SHA512: f9c4f318a1a0d35b8de147d24b72c534a1f58eece31e7cfa00b4149a63b6a618d8ca0312f52fd8056f3c645cf2ee68574ca02319fddffdad919a70cd33395d33
Diffstat (limited to 'test')
0 files changed, 0 insertions, 0 deletions