diff options
| author | fanquake <fanquake@gmail.com> | 2020-12-24 09:18:07 +0800 |
|---|---|---|
| committer | fanquake <fanquake@gmail.com> | 2020-12-24 09:55:27 +0800 |
| commit | 1be6f2dba9b79e54ffdb40ae6ac14cede61232ab (patch) | |
| tree | 3df8f871f18c418648e86a7c9ec0e2de96bd68ea /test | |
| parent | e669c3156ff88627a9478be8a6cac12723c2614a (diff) | |
| parent | 176325a5a47befe32d480b3dc206dd0e64e04b21 (diff) | |
Merge #20747: net processing: Remove dropmessagestest
176325a5a47befe32d480b3dc206dd0e64e04b21 [net processing] Remove dropmessagestest (John Newbery)
Pull request description:
-dropmessagestest is a command line option that causes 1 in n received
messages to be dropped. The Bitcoin P2P protocol is stateful and in
general cannot handle messages being dropped. Dropped
version/verack/ping/pong messages will cause the connection to time out
and be torn down. Other dropped messages may also cause the peer to
believe that the peer has stalled and tear down the connection.
It seems difficult to uncover any actual issues with -dropmessagestest,
and any coverage that could be generated would probably be easier to
trigger with fuzz testing.
ACKs for top commit:
MarcoFalke:
cr ACK 176325a5a47befe32d480b3dc206dd0e64e04b21
practicalswift:
cr ACK 176325a5a47befe32d480b3dc206dd0e64e04b21
dhruv:
cr ACK 176325a
amitiuttarwar:
ACK 176325a5a47befe32d480b3dc206dd0e64e04b21
Tree-SHA512: bd582e5e8c9eb272a5d8ec01ff07c36c0033fbb84c30d1c72c87a7a6c7290021dcaf7bf549179a8b95aeb4f7243158d5593bc7fcf1ec16213782e470fe36bb89
Diffstat (limited to 'test')
0 files changed, 0 insertions, 0 deletions