diff options
| author | MarcoFalke <falke.marco@gmail.com> | 2022-01-28 15:26:21 +0100 |
|---|---|---|
| committer | MarcoFalke <falke.marco@gmail.com> | 2022-01-28 15:26:24 +0100 |
| commit | 1245c62fef1de2df9344e375ee225077fb3d74fa (patch) | |
| tree | 9ac750288e8144a6eb01c91c98372fd65461157b /test | |
| parent | d4e92d843650b0480b86d15ce46ed02b6fd9b5be (diff) | |
| parent | faa75fa19335e3e826efa4f2280609a2db34425d (diff) | |
| download | bitcoin-1245c62fef1de2df9344e375ee225077fb3d74fa.tar.xz | |
Merge bitcoin/bitcoin#24139: Avoid unsigned integer overflow in bitcoin-tx
faa75fa19335e3e826efa4f2280609a2db34425d Avoid unsigned integer overflow in bitcoin-tx (MarcoFalke)
Pull request description:
While `npos` means "largest unsigned value" and adding `1` to it yields `0`, it may be clearer to just assign `0` to it and only increment otherwise.
This also allows to remove a file-wide suppression for `unsigned-integer-overflow`.
ACKs for top commit:
hebasto:
ACK faa75fa19335e3e826efa4f2280609a2db34425d, I have reviewed the code and it looks OK, I agree it can be merged.
theStack:
Code-review ACK faa75fa19335e3e826efa4f2280609a2db34425d
Tree-SHA512: c24436641e5d801341c948b812c7f711d5dff70efdf04af00fd3221f4b81d93f25608dddaa36230ba81ca7ab0d18bdd957095d4561e22621e4d69017934f0a16
Diffstat (limited to 'test')
| -rw-r--r-- | test/sanitizer_suppressions/ubsan | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/test/sanitizer_suppressions/ubsan b/test/sanitizer_suppressions/ubsan index c557f2de92..980e1f5296 100644 --- a/test/sanitizer_suppressions/ubsan +++ b/test/sanitizer_suppressions/ubsan @@ -45,7 +45,6 @@ shift-base:test/fuzz/crypto_diff_fuzz_chacha20.cpp # job. unsigned-integer-overflow:addrman.cpp unsigned-integer-overflow:arith_uint256.h -unsigned-integer-overflow:bitcoin-tx.cpp unsigned-integer-overflow:common/bloom.cpp unsigned-integer-overflow:chain.cpp unsigned-integer-overflow:chain.h |