diff options
| author | MarcoFalke <falke.marco@gmail.com> | 2021-01-04 09:07:01 +0100 |
|---|---|---|
| committer | MarcoFalke <falke.marco@gmail.com> | 2021-01-04 09:07:38 +0100 |
| commit | bc8ada1c15345d14e324aee68488c8aa8a75cae0 (patch) | |
| tree | 7e11c3b95deeb2390863bb23b0a97a6ef81d53ff /test | |
| parent | f52f427b8eece858844c395e47c378864acc242d (diff) | |
| parent | fa749fbea3cad64582f76f7a58cfcc0d91a97326 (diff) | |
| download | bitcoin-bc8ada1c15345d14e324aee68488c8aa8a75cae0.tar.xz | |
Merge #20736: rpc: Replace boost::variant with std::variant for RPCArg.m_fallback
fa749fbea3cad64582f76f7a58cfcc0d91a97326 rpc: Replace boost::variant with std::variant for RPCArg.m_fallback (MarcoFalke)
Pull request description:
Now that we can use std::variant from the vanilla standard library, drop the third-party boost variant dependency.
Patch is split out from #20480. A step-by-step replacement is possible because we don't have our own `Variant` wrapper and the source code specifies `boost::variant` explicitly.
I think a step-by-step replacement should be preferred, because it simplifies review.
ACKs for top commit:
fjahr:
re-ACK fa749fbea3cad64582f76f7a58cfcc0d91a97326
Sjors:
re-ACK fa749fbea3cad64582f76f7a58cfcc0d91a97326
Tree-SHA512: 5e3c12b7d535f73065b4afa8df0a488f78fb25d2234f5ecbf740e624db03a34c35fea100eb7d37e84741721310e6450b7fb4296a2207a7ed1fa24485b3650981
Diffstat (limited to 'test')
| -rw-r--r-- | test/sanitizer_suppressions/ubsan | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/test/sanitizer_suppressions/ubsan b/test/sanitizer_suppressions/ubsan index 291aab0a4a..1af224c57a 100644 --- a/test/sanitizer_suppressions/ubsan +++ b/test/sanitizer_suppressions/ubsan @@ -77,4 +77,6 @@ implicit-signed-integer-truncation:test/skiplist_tests.cpp implicit-signed-integer-truncation:torcontrol.cpp implicit-unsigned-integer-truncation:crypto/* implicit-unsigned-integer-truncation:leveldb/* +# std::variant warning fixed in https://github.com/gcc-mirror/gcc/commit/074436cf8cdd2a9ce75cadd36deb8301f00e55b9 +implicit-unsigned-integer-truncation:std::__detail::__variant::_Variant_storage implicit-integer-sign-change:crc32c/* |