diff options
| author | W. J. van der Laan <laanwj@protonmail.com> | 2021-11-10 13:55:27 +0100 |
|---|---|---|
| committer | W. J. van der Laan <laanwj@protonmail.com> | 2021-11-10 14:20:28 +0100 |
| commit | ed479497bd0468a441083f898e2398d6b901e29e (patch) | |
| tree | d746f40c3ee4d65fd07e024c65d9eba949a06922 /test | |
| parent | 8f86820ff8664ffcb4116a51e6c0b7e6efd47b1f (diff) | |
| parent | aa1a4c920495076ed5b5e3f05cb64d644bab6810 (diff) | |
Merge bitcoin/bitcoin#23398: rpc: add return message to savemempool RPC
aa1a4c920495076ed5b5e3f05cb64d644bab6810 Add file validation to savemempool RPC test (lsilva01)
871e64d22f6db8f2e1b312227354aa172a0347c6 Add filename to savemempool RPC result (lsilva01)
Pull request description:
Currently, if the user calls the `savemempool` RPC method, there is no way to know
where the file was created (unless the user knows internal implementation details).
This PR adds a return message stating the file name and path where the mempool was saved and changes `mempool_persist.py` to validate this new return message.
ACKs for top commit:
laanwj:
Code review ACK aa1a4c920495076ed5b5e3f05cb64d644bab6810
Tree-SHA512: e8b1dd0a8976e5eb15f7476c9651e492d2c621a67e0b726721fa7a2ae0ddd272ee28b87a2d0c650bd635e07fa96bdefe77bece4deb6486ef3ee9a4f83423a840
Diffstat (limited to 'test')
| -rwxr-xr-x | test/functional/mempool_persist.py | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/test/functional/mempool_persist.py b/test/functional/mempool_persist.py index a91fcbd6c7..9bcd4cf6b1 100755 --- a/test/functional/mempool_persist.py +++ b/test/functional/mempool_persist.py @@ -149,8 +149,9 @@ class MempoolPersistTest(BitcoinTestFramework): mempooldat1 = os.path.join(self.nodes[1].datadir, self.chain, 'mempool.dat') self.log.debug("Remove the mempool.dat file. Verify that savemempool to disk via RPC re-creates it") os.remove(mempooldat0) - self.nodes[0].savemempool() + result0 = self.nodes[0].savemempool() assert os.path.isfile(mempooldat0) + assert_equal(result0['filename'], mempooldat0) self.log.debug("Stop nodes, make node1 use mempool.dat from node0. Verify it has 6 transactions") os.rename(mempooldat0, mempooldat1) |