diff options
| author | W. J. van der Laan <laanwj@protonmail.com> | 2021-05-27 15:47:39 +0200 |
|---|---|---|
| committer | W. J. van der Laan <laanwj@protonmail.com> | 2021-05-27 15:52:38 +0200 |
| commit | ea1e5c2c714f4b29a83b1eaf8c9e81006b4cee6a (patch) | |
| tree | 4ba1a4d130c45c7766148f879927e092c06ca37f /test | |
| parent | e20745c1bd1d4493bf7c0e8c595e4148fdeb6f05 (diff) | |
| parent | 8caf60dbbe16afa3c52574a7f6710d74c0bfd4ab (diff) | |
Merge bitcoin/bitcoin#22025: refactor: Group and re-order CAddrMan members by access type
8caf60dbbe16afa3c52574a7f6710d74c0bfd4ab move-only: Group and re-order CAddrMan members by access type (Hennadii Stepanov)
5cd7f8abe3996d303774b6cddeb419337d605d02 refactor: Do not expose CAddrMan members as protected without need (Hennadii Stepanov)
Pull request description:
This PR is split from #19238 as all of its commits are trivial to review.
The last commit is easy to review with `git diff --color-moved=dimmed-zebra`.
Addressed the following comments from #19238:
- https://github.com/bitcoin/bitcoin/pull/19238/commits/130b82ff3588d7207c928bda16b96e720e0b24cd#r550865131
> Can you consolidate all the private members and protected members to be next to each other? Multiple private and protected access specifiers make this harder to read than is necessary.
- https://github.com/bitcoin/bitcoin/pull/19238/commits/130b82ff3588d7207c928bda16b96e720e0b24cd#r557271783
> Yeah, class declaration is easier to read if there is just one instance of `public:`, `protected:` and `private:` (in that order).
ACKs for top commit:
jnewbery:
ACK 8caf60dbbe16afa3c52574a7f6710d74c0bfd4ab
laanwj:
Code review ACK 8caf60dbbe16afa3c52574a7f6710d74c0bfd4ab
jarolrod:
ACK 8caf60dbbe16afa3c52574a7f6710d74c0bfd4ab
vasild:
ACK 8caf60dbbe16afa3c52574a7f6710d74c0bfd4ab
Tree-SHA512: e6127fc658da7876e36f22e2fae162dc19502ed7f8e931fdebc827dabd627e5346c6fbe6f6d0cd27fd3e5c96690ff35022ff6b48f2747b748ebd66a45c851c2b
Diffstat (limited to 'test')
0 files changed, 0 insertions, 0 deletions