diff options
| author | fanquake <fanquake@gmail.com> | 2020-07-03 10:17:52 +0800 |
|---|---|---|
| committer | fanquake <fanquake@gmail.com> | 2020-07-03 10:42:18 +0800 |
| commit | daae8b8a1b035506b9a7d84330afc68263d5e684 (patch) | |
| tree | 003c901112cd0674a283fddf1605ecd89bda0a0b /test | |
| parent | a24806c25d7a81a9c436de58eb5778d93abab16b (diff) | |
| parent | 54b5eb2b149a1f2a4a1dbdb9e0648c5a390d8e22 (diff) | |
Merge #18649: tests: Add std::locale::global to list of locale dependent functions in lint-locale-dependence.sh
54b5eb2b149a1f2a4a1dbdb9e0648c5a390d8e22 tests: Add std::locale::global to list of locale dependent functions in lint-locale-dependence.sh (practicalswift)
Pull request description:
Add `std::locale::global` to list of locale dependent functions in `lint-locale-dependence.sh`.
We currently flag `setlocale(...)` as locale dependent, but prior to this commit we didn't flag
`std::locale::global(...)` as such.
In addition to setting the global C++ locale `std::locale::global(...)` also does the equivalent of `std::setlocale(LC_ALL, ...);`.
Thus the functionality of `std::locale::global(...)` is a superset of `setlocale(...)` :)
ACKs for top commit:
MarcoFalke:
ACK 54b5eb2b149a1f2a4a1dbdb9e0648c5a390d8e22, fine with me
Tree-SHA512: bcf2f1c765add6ed09c3debca968b75eeea81602503f109c0f76ec98635911d453f4834a39e741703c3d470f123178e8952191a9b1a3429394b99c07765dcf1f
Diffstat (limited to 'test')
| -rwxr-xr-x | test/lint/lint-locale-dependence.sh | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/test/lint/lint-locale-dependence.sh b/test/lint/lint-locale-dependence.sh index e2bb403c4d..2e5b801849 100755 --- a/test/lint/lint-locale-dependence.sh +++ b/test/lint/lint-locale-dependence.sh @@ -97,6 +97,7 @@ LOCALE_DEPENDENT_FUNCTIONS=( snprintf sprintf sscanf + std::locale::global std::to_string stod stof |