diff options
| author | Andrew Chow <achow101-github@achow101.com> | 2020-11-18 13:14:19 -0500 |
|---|---|---|
| committer | Jon Atack <jon@atack.com> | 2020-11-19 08:04:05 +0100 |
| commit | 2498b04ce88696a3216fc38b7d393906b733e8b1 (patch) | |
| tree | 87b23a9701e5cc674360578e69594477da19b2fc /test | |
| parent | c46c18b788cb0862aafbb116fd37936cbed6a431 (diff) | |
Don't upgrade to HD split if it is already supported
It is unnecessary to upgrade to FEATURE_HD_SPLIT if this feature is
already supported by the wallet. Because upgrading to FEATURE_HD_SPLIT
actually requires upgrading to FEATURE_PRE_SPLIT_KEYPOOL, users would
accidentally be upgraded to FEATURE_PRE_SPLIT_KEYPOOL instead of nothing
being done.
Fixes the issue described at
https://github.com/bitcoin/bitcoin/pull/20403#discussion_r526063920
Diffstat (limited to 'test')
| -rwxr-xr-x | test/functional/wallet_upgradewallet.py | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/test/functional/wallet_upgradewallet.py b/test/functional/wallet_upgradewallet.py index 8ab4b3f76c..8d3cd16ffc 100755 --- a/test/functional/wallet_upgradewallet.py +++ b/test/functional/wallet_upgradewallet.py @@ -338,6 +338,7 @@ class UpgradeWalletTest(BitcoinTestFramework): new_kvs = dump_bdb_kv(node_master_wallet) up_defaultkey = new_kvs[b'\x0adefaultkey'] assert_equal(defaultkey, up_defaultkey) + assert_equal(wallet.getwalletinfo()["walletversion"], 159900) # 0.16.3 doesn't have a default key v16_3_kvs = dump_bdb_kv(v16_3_wallet) assert b'\x0adefaultkey' not in v16_3_kvs |