diff options
| author | fanquake <fanquake@gmail.com> | 2023-02-20 16:22:41 +0000 |
|---|---|---|
| committer | fanquake <fanquake@gmail.com> | 2023-02-20 16:28:02 +0000 |
| commit | 150cc8ef4289bebc88799f2cbb2860a1aa539c19 (patch) | |
| tree | eea7b9a16b5321dbca29ae43290196b80dda1521 /test | |
| parent | 446c8f581cf3d4eff257f0eb6e43f5248fc4b259 (diff) | |
| parent | 1819564c2130d4d8537ca433c6688b56c769fb79 (diff) | |
Merge bitcoin/bitcoin#27128: test: fix intermittent issue in `p2p_disconnect_ban`
1819564c2130d4d8537ca433c6688b56c769fb79 test: fix intermittent issue in `p2p_disconnect_ban` (brunoerg)
Pull request description:
Fixes #26808
When `node0` calls `disconnectnode` to disconnect `node1`, we should check in `node1` if it worked, because for `node0` the informations in `getpeerinfo` may be updated before really completing the disconnection.
ACKs for top commit:
MarcoFalke:
lgtm ACK 1819564c2130d4d8537ca433c6688b56c769fb79
Tree-SHA512: 53a386fc38e2faa6f6da3536e76857ff4b6f55e2590d73fe857b3fe5d0f3ff92c5c7e4abd50ab4be250cb2106a4d14ad95d4809ea60c6e00ed3ac0e71255b0b0
Diffstat (limited to 'test')
| -rwxr-xr-x | test/functional/p2p_disconnect_ban.py | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/test/functional/p2p_disconnect_ban.py b/test/functional/p2p_disconnect_ban.py index b2f0659eda..394009f30f 100755 --- a/test/functional/p2p_disconnect_ban.py +++ b/test/functional/p2p_disconnect_ban.py @@ -116,7 +116,7 @@ class DisconnectBanTest(BitcoinTestFramework): self.log.info("disconnectnode: successfully disconnect node by address") address1 = self.nodes[0].getpeerinfo()[0]['addr'] self.nodes[0].disconnectnode(address=address1) - self.wait_until(lambda: len(self.nodes[0].getpeerinfo()) == 1, timeout=10) + self.wait_until(lambda: len(self.nodes[1].getpeerinfo()) == 1, timeout=10) assert not [node for node in self.nodes[0].getpeerinfo() if node['addr'] == address1] self.log.info("disconnectnode: successfully reconnect node") @@ -127,7 +127,7 @@ class DisconnectBanTest(BitcoinTestFramework): self.log.info("disconnectnode: successfully disconnect node by node id") id1 = self.nodes[0].getpeerinfo()[0]['id'] self.nodes[0].disconnectnode(nodeid=id1) - self.wait_until(lambda: len(self.nodes[0].getpeerinfo()) == 1, timeout=10) + self.wait_until(lambda: len(self.nodes[1].getpeerinfo()) == 1, timeout=10) assert not [node for node in self.nodes[0].getpeerinfo() if node['id'] == id1] if __name__ == '__main__': |