diff options
| author | Cory Fields <cory-nospam-@coryfields.com> | 2020-05-26 13:43:54 -0400 |
|---|---|---|
| committer | fanquake <fanquake@gmail.com> | 2020-07-01 21:40:51 +0800 |
| commit | f1a0314c537791f202dfb7c1209f0e04ba7988c3 (patch) | |
| tree | 64e3cba6dc9d7650b8788c342c0fc57a942e5e2a /test | |
| parent | bb588669f9e84011969b67f807f12c3480489955 (diff) | |
| download | bitcoin-f1a0314c537791f202dfb7c1209f0e04ba7988c3.tar.xz | |
gui: change combiner for signals to optional_last_value
optional_last_value, which does not throw, has replaced optional_value as
boost's default combiner. Besides being better supported, it also doesn't
trigger gcc's -Wmaybe-unitialized warning, presumably because exceptions no
longer bubble-up out of signals:
```bash
boost/signals2/last_value.hpp:54:36: warning: '*((void*)& value +1)' may be used uninitialized in this function [-Wmaybe-uninitialized]
if(value) return value.get();
```
The change in default happened in Boost 1.39.0 (along with the
introduction of the signals 2 library. More information is available here:
https://www.boost.org/doc/libs/1_73_0/doc/html/signals2/rationale.html#id-1.3.36.9.4
and here:
https://www.boost.org/doc/libs/1_73_0/doc/html/boost/signals2/optional_last_value.html
Co-authored-by: fanquake <fanquake@gmail.com>
Diffstat (limited to 'test')
| -rwxr-xr-x | test/lint/lint-includes.sh | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/test/lint/lint-includes.sh b/test/lint/lint-includes.sh index 5404565b94..611bd4a8c4 100755 --- a/test/lint/lint-includes.sh +++ b/test/lint/lint-includes.sh @@ -64,7 +64,7 @@ EXPECTED_BOOST_INCLUDES=( boost/preprocessor/cat.hpp boost/preprocessor/stringize.hpp boost/signals2/connection.hpp - boost/signals2/last_value.hpp + boost/signals2/optional_last_value.hpp boost/signals2/signal.hpp boost/test/unit_test.hpp boost/thread/condition_variable.hpp |