diff options
author | MarcoFalke <falke.marco@gmail.com> | 2020-11-05 18:45:03 +0100 |
---|---|---|
committer | MarcoFalke <falke.marco@gmail.com> | 2020-11-05 18:45:05 +0100 |
commit | f5cdc290d5a41895d2bbaf474c3a951e5141b8a9 (patch) | |
tree | 20d33e4b73e8dca2cc466081754b8106cb465eb0 /test | |
parent | 9bb078351b09862a263e936bb612dca82305a6fe (diff) | |
parent | fa00ff0399fe54f42d80daa04140d19bcfe0e2d8 (diff) |
Merge #20316: test: Fix wallet_multiwallet test issue on Windows
fa00ff0399fe54f42d80daa04140d19bcfe0e2d8 test: Fix wallet_multiwallet test issue on Windows (MarcoFalke)
Pull request description:
Fixes:
```
Traceback (most recent call last):
File "test\functional\test_framework\test_framework.py", line 126, in main
self.run_test()
File "test/functional/wallet_multiwallet.py", line 120, in run_test
assert_equal(sorted(map(lambda w: w['name'], self.nodes[0].listwalletdir()['wallets'])), sorted(in_wallet_dir))
File "test\functional\test_framework\util.py", line 49, in assert_equal
raise AssertionError("not(%s)" % " == ".join(str(arg) for arg in (thing1, thing2) + args))
AssertionError: not(['', 'sub\\w5', 'w', 'w1', 'w2', 'w3', 'w7', 'w7_symlink', 'w8'] == ['', 'sub/w5', 'w', 'w1', 'w2', 'w3', 'w7', 'w7_symlink', 'w8'])
ACKs for top commit:
promag:
ACK fa00ff0399fe54f42d80daa04140d19bcfe0e2d8.
Tree-SHA512: 7a809a352677a216465cef59e866e4881272e302e897cebf7d9645bf87aebeaf54435bb0692bb5c1381c2dd680e8a34e640ea18ca6e2a4087e3233cd9c24ed04
Diffstat (limited to 'test')
-rwxr-xr-x | test/functional/wallet_multiwallet.py | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/test/functional/wallet_multiwallet.py b/test/functional/wallet_multiwallet.py index 3f6a17269e..abdc279197 100755 --- a/test/functional/wallet_multiwallet.py +++ b/test/functional/wallet_multiwallet.py @@ -104,14 +104,14 @@ class MultiWalletTest(BitcoinTestFramework): # w8 - to verify existing wallet file is loaded correctly. Not tested for SQLite wallets as this is a deprecated BDB behavior. # '' - to verify default wallet file is created correctly to_create = ['w1', 'w2', 'w3', 'w', 'sub/w5', 'w7_symlink'] - in_wallet_dir = to_create.copy() # Wallets in the wallet dir - in_wallet_dir.append('w7') # w7 is not loaded or created, but will be listed by listwalletdir because w7_symlink - to_create.append(os.path.join(self.options.tmpdir, 'extern/w6')) # External, not in the wallet dir, so we need to avoid adding it to in_wallet_dir + in_wallet_dir = [w.replace('/', os.path.sep) for w in to_create] # Wallets in the wallet dir + in_wallet_dir.append('w7') # w7 is not loaded or created, but will be listed by listwalletdir because w7_symlink + to_create.append(os.path.join(self.options.tmpdir, 'extern/w6')) # External, not in the wallet dir, so we need to avoid adding it to in_wallet_dir to_load = [self.default_wallet_name] if not self.options.descriptors: to_load.append('w8') - wallet_names = to_create + to_load # Wallet names loaded in the wallet - in_wallet_dir += to_load # The loaded wallets are also in the wallet dir + wallet_names = to_create + to_load # Wallet names loaded in the wallet + in_wallet_dir += to_load # The loaded wallets are also in the wallet dir self.start_node(0) for wallet_name in to_create: self.nodes[0].createwallet(wallet_name) @@ -298,7 +298,6 @@ class MultiWalletTest(BitcoinTestFramework): # Fail to load if one wallet is a copy of another, test this twice to make sure that we don't re-introduce #14304 assert_raises_rpc_error(-4, "BerkeleyDatabase: Can't open database w8_copy (duplicates fileid", self.nodes[0].loadwallet, 'w8_copy') - # Fail to load if wallet file is a symlink assert_raises_rpc_error(-4, "Wallet file verification failed. Invalid -wallet path 'w8_symlink'", self.nodes[0].loadwallet, 'w8_symlink') @@ -397,5 +396,6 @@ class MultiWalletTest(BitcoinTestFramework): self.nodes[0].unloadwallet(wallet) self.nodes[1].loadwallet(wallet) + if __name__ == '__main__': MultiWalletTest().main() |