diff options
| author | Wladimir J. van der Laan <laanwj@gmail.com> | 2018-12-19 16:02:26 +0100 |
|---|---|---|
| committer | Wladimir J. van der Laan <laanwj@gmail.com> | 2018-12-19 16:03:34 +0100 |
| commit | cb52cee29d0d8be062c22e59299b8e332da340c5 (patch) | |
| tree | 5658ab9d9569f9c46f7c0b6d417e4972359aa878 /test | |
| parent | f080c65a09a8f3b223c9b5d8e3562320bf258fcd (diff) | |
| parent | 6c10037f72073eecc674c313580ef50a4f1e1e44 (diff) | |
| download | bitcoin-cb52cee29d0d8be062c22e59299b8e332da340c5.tar.xz | |
Merge #14993: rpc: Fix data race (UB) in InterruptRPC()
6c10037f72073eecc674c313580ef50a4f1e1e44 rpc: Fix data race (UB) in InterruptRPC() (practicalswift)
Pull request description:
Fix data race (UB) in `InterruptRPC()`.
Before:
```
$ ./configure --with-sanitizers=thread
$ make
$ test/functional/test_runner.py feature_shutdown.py
…
SUMMARY: ThreadSanitizer: data race rpc/server.cpp:314 in InterruptRPC()
…
ALL | ✖ Failed | 2 s (accumulated)
```
After:
```
$ ./configure --with-sanitizers=thread
$ make
$ test/functional/test_runner.py feature_shutdown.py
…
ALL | ✓ Passed | 3 s (accumulated)
```
Tree-SHA512: b139ca1a0480258f8caa7730cabd7783a821d906630f51487750a6b15b7842675ed679747e1ff1bdade77d248807e9d77bae7bb88da54d1df84a179cd9b9b987
Diffstat (limited to 'test')
| -rw-r--r-- | test/sanitizer_suppressions/tsan | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/test/sanitizer_suppressions/tsan b/test/sanitizer_suppressions/tsan index 593e1f54ff..70eea34363 100644 --- a/test/sanitizer_suppressions/tsan +++ b/test/sanitizer_suppressions/tsan @@ -7,9 +7,6 @@ deadlock:WalletBatch # Intentional deadlock in tests deadlock:TestPotentialDeadLockDetected -# fRPCRunning race -race:InterruptRPC - # Wildcard for all gui tests, should be replaced with non-wildcard suppressions race:src/qt/test/* deadlock:src/qt/test/* |