diff options
| author | MarcoFalke <falke.marco@gmail.com> | 2020-10-01 13:28:24 +0200 |
|---|---|---|
| committer | MarcoFalke <falke.marco@gmail.com> | 2020-10-01 13:29:05 +0200 |
| commit | 9fc2f011ba1724b3f43b7ed228084095bfd78930 (patch) | |
| tree | fd4cdb86d939d4171c90592b1d7ed258c06a490e /test | |
| parent | 40aab35e9828427a800916ac15e3381332f4d0a6 (diff) | |
| parent | 6fccad7f711df330e461c1fab3f758d078345ed5 (diff) | |
| download | bitcoin-9fc2f011ba1724b3f43b7ed228084095bfd78930.tar.xz | |
Merge #20048: chainparams: do not log signet startup messages for other chains
6fccad7f711df330e461c1fab3f758d078345ed5 signet: do not log signet startup messages for other chains (Jon Atack)
Pull request description:
The following signet startup messages are printed to the debug log immediately on node startup for all chains. This behavior occurs on master as a side effect after the merge of #20014. This PR removes the first message and moves the signet derived magic logging to `init.cpp`.
```
$ ./src/bitcoind
2020-09-30T14:25:15Z Using default signet network
2020-09-30T14:25:15Z Signet derived magic (message start): 0a03cf40
2020-09-30T14:25:15Z Bitcoin Core version v0.20.99.0 ...
```
ACKs for top commit:
MarcoFalke:
ACK 6fccad7f711df330e461c1fab3f758d078345ed5
kallewoof:
utACK 6fccad7f711df330e461c1fab3f758d078345ed5
hebasto:
ACK 6fccad7f711df330e461c1fab3f758d078345ed5
Tree-SHA512: 33821dce89b24caf7b7c1ecb41e572ecfb26e6958a1316d359ff240e6ef97c4a1f2cf1b4b974596b252815f9df23960ce385c132ebdbc855bbe6123c3b0b003a
Diffstat (limited to 'test')
| -rwxr-xr-x | test/functional/feature_signet.py | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/test/functional/feature_signet.py b/test/functional/feature_signet.py index a0e7f3ee6e..96c581dede 100755 --- a/test/functional/feature_signet.py +++ b/test/functional/feature_signet.py @@ -65,6 +65,10 @@ class SignetBasicTest(BitcoinTestFramework): assert_equal(self.nodes[4].submitblock(signet_blocks[0]), 'bad-signet-blksig') + self.log.info("test that signet logs the network magic on node start") + with self.nodes[0].assert_debug_log(["Signet derived magic (message start)"]): + self.restart_node(0) + if __name__ == '__main__': SignetBasicTest().main() |