diff options
| author | fanquake <fanquake@gmail.com> | 2024-01-18 09:35:36 +0000 |
|---|---|---|
| committer | fanquake <fanquake@gmail.com> | 2024-01-18 09:40:44 +0000 |
| commit | 03c5b0064d4f766bc8dc6508773c7579e9ad39bc (patch) | |
| tree | 0ee3018b6ebe23dcd75a6fd442754a0bea1db800 /test | |
| parent | 3d52cedb497e0ec029ba3cef95b00169c157d8ae (diff) | |
| parent | 60446285436da62adef1c0a9b11c3336d82b4d89 (diff) | |
Merge bitcoin/bitcoin#29085: refactor: C++20: Use std::rotl
60446285436da62adef1c0a9b11c3336d82b4d89 crypto, hash: replace custom rotl32 with std::rotl (Fabian Jahr)
Pull request description:
While exploring some C++20 changes and checking against our code I found this potential improvement:
1. We can replace our custom implementation of `rotl32` in crypto/chacha20 with `std::rotl` from the [new `bit` header](https://en.cppreference.com/w/cpp/header/bit).
ACKs for top commit:
fanquake:
ACK 60446285436da62adef1c0a9b11c3336d82b4d89
Tree-SHA512: db55b366f20fca2ef62e5f10a838f8a709d531678c35c1dba20898754029c788a2fd47995208ed6d187cf814109a7ca397bc2c301504500aee79da04c95d6895
Diffstat (limited to 'test')
| -rw-r--r-- | test/sanitizer_suppressions/ubsan | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/test/sanitizer_suppressions/ubsan b/test/sanitizer_suppressions/ubsan index f0ee698909..b22caa15a5 100644 --- a/test/sanitizer_suppressions/ubsan +++ b/test/sanitizer_suppressions/ubsan @@ -69,7 +69,6 @@ implicit-signed-integer-truncation:crypto/ implicit-unsigned-integer-truncation:crypto/ shift-base:arith_uint256.cpp shift-base:crypto/ -shift-base:ROTL32 shift-base:streams.h shift-base:FormatHDKeypath shift-base:xoroshiro128plusplus.h |