diff options
| author | Wladimir J. van der Laan <laanwj@gmail.com> | 2019-01-30 20:16:41 +0100 |
|---|---|---|
| committer | Wladimir J. van der Laan <laanwj@gmail.com> | 2019-01-30 20:22:57 +0100 |
| commit | 77339e5c244b183dd6e8d93f6b7bdf1d00849024 (patch) | |
| tree | 546700c64686dccdfaba62e87e8d78717db87eea /test | |
| parent | 04226f8706b5d404da41b56c2e24c5dbc68443b2 (diff) | |
| parent | 6f6514a08090b37b5e8c086015ee4881813ef867 (diff) | |
| download | bitcoin-77339e5c244b183dd6e8d93f6b7bdf1d00849024.tar.xz | |
Merge #15163: Correct units for "-dbcache" and "-prune"
6f6514a08090b37b5e8c086015ee4881813ef867 Correct units for "-dbcache" and "-prune" (Hennadii Stepanov)
Pull request description:
Actually, all `dbcache`-related values in the code are measured in MiB (not in megabytes, MB) or in bytes (e.g., `nTotalCache`).
See: https://github.com/bitcoin/bitcoin/blob/master/src/txdb.h
https://github.com/bitcoin/bitcoin/blob/ba8c8b22272ad40fe2de465d7e745532bab48d3b/src/init.cpp#L1405-L1424
Also, "-prune" is fixed:
1. The GUI values in GB are translated to the node values in MiB correctly.
2. The maximum of the "prune" `QSpinBox` is not limited by default value of 99 (GB).
Fix: #15106
Tree-SHA512: 151ec43b31b1074db8b345fedb1dcc10bde225899a5296bfc183f57e1553d13ac27db8db100226646769ad03c9fcab29d88763065a471757c6c41ac51108459d
Diffstat (limited to 'test')
| -rwxr-xr-x | test/functional/feature_pruning.py | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/test/functional/feature_pruning.py b/test/functional/feature_pruning.py index 9a3f4fae45..3e1ba88f0a 100755 --- a/test/functional/feature_pruning.py +++ b/test/functional/feature_pruning.py @@ -320,7 +320,7 @@ class PruneTest(BitcoinTestFramework): if has_block(3): raise AssertionError("blk00003.dat is still there, should be pruned by now") - # stop node, start back up with auto-prune at 550MB, make sure still runs + # stop node, start back up with auto-prune at 550 MiB, make sure still runs self.stop_node(node_number) self.start_node(node_number, extra_args=["-prune=550"]) |