diff options
| author | Samuel Dobson <dobsonsa68@gmail.com> | 2019-09-14 21:42:34 +1200 |
|---|---|---|
| committer | Samuel Dobson <dobsonsa68@gmail.com> | 2019-09-14 21:45:30 +1200 |
| commit | 4bfef0daeb9351c200b5bd09e60596a29b4d3523 (patch) | |
| tree | cc31c38c3d8aaf300645db7e84ddb877b5e89fcd /test | |
| parent | fb4f5beb6ede4aadeaff779cd67a0f6665419488 (diff) | |
| parent | 7dee8f48088c75ab0e51be60679505f8ce570919 (diff) | |
Merge #16866: wallet: Rename 'decode' argument in gettransaction method to 'verbose'
7dee8f48088c75ab0e51be60679505f8ce570919 [wallet] Rename 'decode' argument in gettransaction method to 'verbose' (John Newbery)
Pull request description:
This makes the RPC method consistent with other RPC methods that have a
'verbose' option.
Change the name of the return object from 'decoded' to details.
Update help text.
ACKs for top commit:
promag:
ACK 7dee8f48088c75ab0e51be60679505f8ce570919.
meshcollider:
Code review ACK 7dee8f48088c75ab0e51be60679505f8ce570919
0xB10C:
ACK 7dee8f48088c75ab0e51be60679505f8ce570919: reviewed code
Tree-SHA512: a3a62265c8e6e914591f3b3b9f9dd4f42240dc8dab9cbac6ed8d8b8319b6cc847db2ad1689d5440c162e0698f31e39fc6b868ed918b2f62879d61b9865cae66b
Diffstat (limited to 'test')
| -rwxr-xr-x | test/functional/wallet_basic.py | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/test/functional/wallet_basic.py b/test/functional/wallet_basic.py index 74350649c7..4c3fe3078b 100755 --- a/test/functional/wallet_basic.py +++ b/test/functional/wallet_basic.py @@ -499,10 +499,10 @@ class WalletTest(BitcoinTestFramework): self.nodes[0].setlabel(change, 'foobar') assert_equal(self.nodes[0].getaddressinfo(change)['ischange'], False) - # Test "decoded" field value in gettransaction response - self.log.info("Testing gettransaction decoding...") - tx = self.nodes[0].gettransaction(txid=txid, decode=True) - assert_equal(tx["decoded"], self.nodes[0].decoderawtransaction(tx["hex"])) + # Test "verbose" field value in gettransaction response + self.log.info("Testing verbose gettransaction...") + tx = self.nodes[0].gettransaction(txid=txid, verbose=True) + assert_equal(tx["details"], self.nodes[0].decoderawtransaction(tx["hex"])) if __name__ == '__main__': |