diff options
| author | Wladimir J. van der Laan <laanwj@gmail.com> | 2017-09-25 13:16:51 +0200 |
|---|---|---|
| committer | Wladimir J. van der Laan <laanwj@gmail.com> | 2017-09-25 13:16:56 +0200 |
| commit | 8cf88b4aaeaf4f7446fea6dc6d2402a9cc9368eb (patch) | |
| tree | 9a7463963b6e5a0e5d5d8b20d1e49cae5dbaa6d7 /test | |
| parent | 2d858993035f3b969d0fa741efc0857f434c696f (diff) | |
| parent | 13baf7217bf8394ae02efc376208ae86eac4d0f6 (diff) | |
| download | bitcoin-8cf88b4aaeaf4f7446fea6dc6d2402a9cc9368eb.tar.xz | |
Merge #11335: Replace save|restoreWindowGeometry with Qt functions
13baf72 Replace save|restoreWindowGeometry with Qt functions (MeshCollider)
Pull request description:
Alternative to https://github.com/bitcoin/bitcoin/pull/11208, closes https://github.com/bitcoin/bitcoin/issues/11207
According to the [Qt documentation](https://doc.qt.io/qt-4.8/qwidget.html#restoreGeometry), restoreGeometry does all the checks we need, so it would be better to rely on them instead of doing it ourselves.
~Haven't tested this properly yet, hence the WIP.~
Gives expected behavior exactly as the other system apps do based on my tests. Only potential issue is the case when the GUI is almost entirely offscreen with only a single strip of pixels, its not really possible to see the GUI, but if you know it's there you can bring it back onscreen with just the mouse. And that's exactly how notepad behaves on Windows so I don't think its a real issue.
This also gives much better behavior when closing a maximized window, currently (0.15.0 release) a maximized window will save the window size on close, and then reopen as a not-maximized but still that size, which is really annoying. This reopens as maximized.
Gitian build here: https://bitcoin.jonasschnelli.ch/build/305
Tree-SHA512: a8bde14793b4316192df1fa2eaaeb32b44d5ebc5219c35252379840056cd737a9fd162625fd715987f275fec8375334ec1ec328dbc671563f084c611a938985c
Diffstat (limited to 'test')
0 files changed, 0 insertions, 0 deletions