diff options
| author | Suhas Daftuar <sdaftuar@chaincode.com> | 2017-09-13 09:17:15 -0400 |
|---|---|---|
| committer | MarcoFalke <falke.marco@gmail.com> | 2017-10-03 22:03:09 +0200 |
| commit | 2f0b30a58a07a3e30faa82a27525025158754db2 (patch) | |
| tree | 4551800f3d8c006e8072ead5f5a9facf9f02f613 /test | |
| parent | e4605d9dd498a1fa713e6a916347a7c887f2c2b8 (diff) | |
| download | bitcoin-2f0b30a58a07a3e30faa82a27525025158754db2.tar.xz | |
qa: Treat mininode p2p exceptions as fatal
Github-Pull: #11319
Rebased-From: a7820422e0b182db6f1df8904242e5d76d6c73fa
Diffstat (limited to 'test')
| -rwxr-xr-x | test/functional/test_framework/mininode.py | 14 |
1 files changed, 7 insertions, 7 deletions
diff --git a/test/functional/test_framework/mininode.py b/test/functional/test_framework/mininode.py index 5924530230..843b67cd5c 100755 --- a/test/functional/test_framework/mininode.py +++ b/test/functional/test_framework/mininode.py @@ -1505,6 +1505,7 @@ class NodeConnCB(object): except: print("ERROR delivering %s (%s)" % (repr(message), sys.exc_info()[0])) + raise def set_deliver_sleep_time(self, value): with mininode_lock: @@ -1708,13 +1709,10 @@ class NodeConn(asyncore.dispatcher): self.cb.on_close(self) def handle_read(self): - try: - t = self.recv(8192) - if len(t) > 0: - self.recvbuf += t - self.got_data() - except: - pass + t = self.recv(8192) + if len(t) > 0: + self.recvbuf += t + self.got_data() def readable(self): return True @@ -1780,8 +1778,10 @@ class NodeConn(asyncore.dispatcher): self.got_message(t) else: logger.warning("Received unknown command from %s:%d: '%s' %s" % (self.dstaddr, self.dstport, command, repr(msg))) + raise ValueError("Unknown command: '%s'" % (command)) except Exception as e: logger.exception('got_data:', repr(e)) + raise def send_message(self, message, pushbuf=False): if self.state != "connected" and not pushbuf: |