diff options
author | fanquake <fanquake@gmail.com> | 2022-01-10 10:57:55 +0800 |
---|---|---|
committer | fanquake <fanquake@gmail.com> | 2022-01-10 10:59:52 +0800 |
commit | 542e405a8517e50bf6687a02af69117931234fde (patch) | |
tree | d2e232a9e8d4c964ea3fb8a71c24cc9611cd8f7d /test/util/data/txcreatesignsegwit1.hex | |
parent | 2e01b6986099715afa40ed6464da4b321b630e9c (diff) | |
parent | 6200fbf54fa919899d99f1cdd5ef88ec8b074cd6 (diff) | |
download | bitcoin-542e405a8517e50bf6687a02af69117931234fde.tar.xz |
Merge bitcoin/bitcoin#23724: build: add systemtap's sys/sdt.h as depends for GUIX builds with USDT tracepoints
6200fbf54fa919899d99f1cdd5ef88ec8b074cd6 build: rename --enable-ebpf to --enable-usdt (0xb10c)
e158a2a7aa501da635cb34414abd0c092216e5f4 build: add systemtap's sys/sdt.h as depends (0xb10c)
Pull request description:
There has been light conceptual agreement on including the Userspace, Statically Defined Tracing tracepoints in Bitcoin Core release builds. This, for example, enables user to hook into production deployments, if they need to. Binaries don't have to be switched out. This is possible because we don't do [expensive computations](https://github.com/bitcoin/bitcoin/blob/master/doc/tracing.md#no-expensive-computations-for-tracepoints) only needed for the tracepoints. The tracepoints are NOPs when not used.
Systemtap's `sys/sdt.h` header is required to build Bitcoin Core with USDT support. The header file defines the `DTRACE_PROBE` macros used in [`src/util/trace.h`](https://github.com/bitcoin/bitcoin/blob/master/src/util/trace.h). This PR adds Systemtap 4.5 (May 2021) as dependency. GUIX builds for Linux hosts now include the tracepoints.
Closes https://github.com/bitcoin/bitcoin/issues/23297.
ACKs for top commit:
fanquake:
ACK 6200fbf54fa919899d99f1cdd5ef88ec8b074cd6 - tested enabling / disabling and with/without SDT from depends. We can follow up with #23819, #23907 and #23296, and if any serious issues arise before feature freeze, it is easy for us to flip depends such that USDT becomes opt-in, rather than opt-out, and thus, releases would be tracepoint free.
Tree-SHA512: 0263f44892bf8450e8a593e4de7a498243687f8d81269e1c3283fa8354922c7cf93fddef4b92cf5192d33798424aa5812e03e68ef8de31af078a32dd34021382
Diffstat (limited to 'test/util/data/txcreatesignsegwit1.hex')
0 files changed, 0 insertions, 0 deletions