diff options
| author | Wladimir J. van der Laan <laanwj@protonmail.com> | 2020-02-12 17:48:22 +0100 |
|---|---|---|
| committer | Wladimir J. van der Laan <laanwj@protonmail.com> | 2020-02-12 17:48:30 +0100 |
| commit | 2bdc476d4d23256d8396bb9051a511f540d87392 (patch) | |
| tree | 0c53a9b7c3b0522801db923d85c52876f3940f40 /test/sanitizer_suppressions/ubsan | |
| parent | d4fc9aeb8b6a66d8d40ab93547c8b1390458d638 (diff) | |
| parent | 5f26855f109af53a336d5f98ed0ae584e7a31f84 (diff) | |
| download | bitcoin-2bdc476d4d23256d8396bb9051a511f540d87392.tar.xz | |
Merge #17708: prevector: avoid misaligned member accesses
5f26855f109af53a336d5f98ed0ae584e7a31f84 test: Remove ubsan alignment suppressions (Wladimir J. van der Laan)
9d933ef9191417b4b7d29eaa3c3a571f814acc8e prevector: avoid misaligned member accesses (Anthony Towns)
Pull request description:
Ensure prevector data is appropriately aligned. Earlier discussion in #17530.
**Edit laanwj**: In contrast to #17530, it does this without increase in size of any of the coin cache data structures (x86_64, clang)
| Struct | (size,align) before | (size,align) after |
| ------------- | ------------- | ------- |
| Coin | 48, 8 | 48, 8 |
| CCoinsCacheEntry | 56, 8 | 56, 8 |
| CScript | 32, 1 | 32, 8 |
ACKs for top commit:
laanwj:
ACK 5f26855f109af53a336d5f98ed0ae584e7a31f84
practicalswift:
ACK 5f26855f109af53a336d5f98ed0ae584e7a31f84
jonatack:
ACK 5f26855f109af53a336d5f98ed0ae584e7a31f84
Tree-SHA512: 98d112d6856f683d5b212410b73f3071d2994f1efb046a2418a35890aa1cf1aa7c96a960fc2e963fa15241e861093c1ea41951cf5b4b5431f88345eb1dd0a98a
Diffstat (limited to 'test/sanitizer_suppressions/ubsan')
| -rw-r--r-- | test/sanitizer_suppressions/ubsan | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/test/sanitizer_suppressions/ubsan b/test/sanitizer_suppressions/ubsan index 098dd29260..b3d9b9e6ec 100644 --- a/test/sanitizer_suppressions/ubsan +++ b/test/sanitizer_suppressions/ubsan @@ -1,7 +1,5 @@ # -fsanitize=undefined suppressions # ================================= -alignment:move.h -alignment:prevector.h float-divide-by-zero:policy/fees.cpp float-divide-by-zero:validation.cpp float-divide-by-zero:wallet/wallet.cpp |