diff options
| author | W. J. van der Laan <laanwj@protonmail.com> | 2021-09-30 14:47:03 +0200 |
|---|---|---|
| committer | W. J. van der Laan <laanwj@protonmail.com> | 2021-09-30 15:14:58 +0200 |
| commit | 2d8e0c0c3c0d3c4cee7bb52d1edf501f40c53463 (patch) | |
| tree | 8266dac1d118b5985f5f84b1550752198bc21f38 /test/lint | |
| parent | 1cf7fb9fd65820b298a0eb28f6e2c4c7409c78d1 (diff) | |
| parent | 4747db876154ddd828c03d9eda10ecf8b25d8dc8 (diff) | |
| download | bitcoin-2d8e0c0c3c0d3c4cee7bb52d1edf501f40c53463.tar.xz | |
Merge bitcoin/bitcoin#20457: util: Make Parse{Int,UInt}{32,64} use locale independent std::from_chars(…) (C++17) instead of locale dependent strto{l,ll,ul,ull}
4747db876154ddd828c03d9eda10ecf8b25d8dc8 util: Introduce ToIntegral<T>(const std::string&) for locale independent parsing using std::from_chars(…) (C++17) (practicalswift)
Pull request description:
Make `Parse{Int,UInt}{32,64}` use locale independent `std::from_chars(…)` (C++17) instead of locale dependent `strto{l,ll,ul,ull}`.
[About `std::from_chars`](https://en.cppreference.com/w/cpp/utility/from_chars): _"Unlike other parsing functions in C++ and C libraries, `std::from_chars` is locale-independent, non-allocating, and non-throwing."_
ACKs for top commit:
laanwj:
Code review ACK 4747db876154ddd828c03d9eda10ecf8b25d8dc8
Tree-SHA512: 40f2cd582bc19ddcf2c498eca3379167619eff6aa047bbac2f73b8fd8ecaefe5947c66700a189f83848751f9f8c05645e83afd4a44a1679062aee5440dba880a
Diffstat (limited to 'test/lint')
| -rwxr-xr-x | test/lint/lint-locale-dependence.sh | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/test/lint/lint-locale-dependence.sh b/test/lint/lint-locale-dependence.sh index d6312270e7..fcc4883d0b 100755 --- a/test/lint/lint-locale-dependence.sh +++ b/test/lint/lint-locale-dependence.sh @@ -47,11 +47,11 @@ KNOWN_VIOLATIONS=( "src/test/dbwrapper_tests.cpp:.*snprintf" "src/test/fuzz/locale.cpp" "src/test/fuzz/parse_numbers.cpp:.*atoi" + "src/test/fuzz/string.cpp" "src/torcontrol.cpp:.*atoi" "src/torcontrol.cpp:.*strtol" "src/util/strencodings.cpp:.*atoi" - "src/util/strencodings.cpp:.*strtol" - "src/util/strencodings.cpp:.*strtoul" + "src/util/strencodings.cpp:.*strtoll" "src/util/strencodings.h:.*atoi" "src/util/system.cpp:.*atoi" ) |