diff options
| author | glozow <gloriajzhao@gmail.com> | 2021-09-29 20:52:04 +0100 |
|---|---|---|
| committer | glozow <gloriajzhao@gmail.com> | 2021-11-30 12:21:56 +0000 |
| commit | a64078e38563ef3ac5e5ec20c07569441c87eeee (patch) | |
| tree | 3a4968f341333b819884b28e94f74007fd24c1fe /test/lint | |
| parent | 64e4963c635ec3a73a5fa3f32f6ec08e70609f60 (diff) | |
| download | bitcoin-a64078e38563ef3ac5e5ec20c07569441c87eeee.tar.xz | |
Break validation <-> txmempool circular dependency
No behavior change.
Parameterize removeForReorg using a CChain and callable that
encapsulates validation logic. The mempool shouldn't need to know a
bunch of details about coinbase maturity and lock finality. Instead,
just pass in a callable function that says true/false. Breaks circular
dependency by removing txmempool's dependency on validation.
Diffstat (limited to 'test/lint')
| -rwxr-xr-x | test/lint/lint-circular-dependencies.sh | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/test/lint/lint-circular-dependencies.sh b/test/lint/lint-circular-dependencies.sh index ab3866d23e..69185090d1 100755 --- a/test/lint/lint-circular-dependencies.sh +++ b/test/lint/lint-circular-dependencies.sh @@ -15,12 +15,10 @@ EXPECTED_CIRCULAR_DEPENDENCIES=( "index/base -> validation -> index/blockfilterindex -> index/base" "index/coinstatsindex -> node/coinstats -> index/coinstatsindex" "policy/fees -> txmempool -> policy/fees" - "policy/rbf -> txmempool -> validation -> policy/rbf" "qt/addresstablemodel -> qt/walletmodel -> qt/addresstablemodel" "qt/recentrequeststablemodel -> qt/walletmodel -> qt/recentrequeststablemodel" "qt/sendcoinsdialog -> qt/walletmodel -> qt/sendcoinsdialog" "qt/transactiontablemodel -> qt/walletmodel -> qt/transactiontablemodel" - "txmempool -> validation -> txmempool" "wallet/fees -> wallet/wallet -> wallet/fees" "wallet/wallet -> wallet/walletdb -> wallet/wallet" "node/coinstats -> validation -> node/coinstats" |