aboutsummaryrefslogtreecommitdiff
path: root/test/lint
diff options
context:
space:
mode:
authorpracticalswift <practicalswift@users.noreply.github.com>2018-08-07 14:57:54 +0200
committerpracticalswift <practicalswift@users.noreply.github.com>2018-08-07 14:57:54 +0200
commitbcd4b0f5cdde2a1b562a612c78ec1ef1fe47d3dd (patch)
treee2e417d5e2294ba0ab2db097b7e955e5a2ccf01f /test/lint
parenta3e455694901a887e0feef69bd63e3aa122ea44b (diff)
downloadbitcoin-bcd4b0f5cdde2a1b562a612c78ec1ef1fe47d3dd.tar.xz
Add linting of WalletLogPrintf(...) format strings
Diffstat (limited to 'test/lint')
-rwxr-xr-xtest/lint/lint-format-strings.py2
-rwxr-xr-xtest/lint/lint-format-strings.sh1
2 files changed, 3 insertions, 0 deletions
diff --git a/test/lint/lint-format-strings.py b/test/lint/lint-format-strings.py
index dcdd1dcf7e..c07dfe317b 100755
--- a/test/lint/lint-format-strings.py
+++ b/test/lint/lint-format-strings.py
@@ -18,6 +18,8 @@ FALSE_POSITIVES = [
("src/netbase.cpp", "LogConnectFailure(bool manual_connection, const char* fmt, const Args&... args)"),
("src/util.cpp", "strprintf(_(COPYRIGHT_HOLDERS), _(COPYRIGHT_HOLDERS_SUBSTITUTION))"),
("src/util.cpp", "strprintf(COPYRIGHT_HOLDERS, COPYRIGHT_HOLDERS_SUBSTITUTION)"),
+ ("src/wallet/wallet.h", "WalletLogPrintf(std::string fmt, Params... parameters)"),
+ ("src/wallet/wallet.h", "LogPrintf((\"%s \" + fmt).c_str(), GetDisplayName(), parameters...)"),
]
diff --git a/test/lint/lint-format-strings.sh b/test/lint/lint-format-strings.sh
index c4041d4b3d..17f846d29b 100755
--- a/test/lint/lint-format-strings.sh
+++ b/test/lint/lint-format-strings.sh
@@ -24,6 +24,7 @@ FUNCTION_NAMES_AND_NUMBER_OF_LEADING_ARGUMENTS=(
vprintf,1
vsnprintf,1
vsprintf,1
+ WalletLogPrintf,0
)
EXIT_CODE=0