diff options
| author | glozow <gloriajzhao@gmail.com> | 2024-01-12 11:51:44 +0000 |
|---|---|---|
| committer | glozow <gloriajzhao@gmail.com> | 2024-01-12 12:03:52 +0000 |
| commit | cd603361a4b675fabdaa65521b31b42f439fa485 (patch) | |
| tree | 7364931c6a44a18d644ce1341d7e2b95e7412f9d /test/lint/lint-format-strings.py | |
| parent | 8c5e4f42d502f55349d45aaf2c208cf1ddc31d4b (diff) | |
| parent | 0eebd6fe7d01ddc7f6b7f13a6ed6e705c7aeae4e (diff) | |
Merge bitcoin/bitcoin#28885: mempool / rpc: followup to getprioritisedtransactions and delete a mapDeltas entry when delta==0
0eebd6fe7d01ddc7f6b7f13a6ed6e705c7aeae4e test: Assert that a new tx with a delta of 0 is never added (kevkevin)
cfdbcd19b32fd63954d7947dcc639aef291fb6b2 rpc: exposing modified_fee in getprioritisedtransactions (kevkevin)
252a86729a15e47ed168d8da7c4a8d6113673909 rpc: renaming txid -> transactionid (kevkevin)
2fca6c2dd03c3955d86efb0b8d2a7961e42115fd rpc: changed prioritisation-map -> "" (kevkevin)
3a118e19e100110300d3290d4c1434f963721d94 test: Directly constructing 2 entry map for getprioritisedtransactions (kevkevin)
Pull request description:
In this PR I am addressing some comments in https://github.com/bitcoin/bitcoin/pull/27501 as a followup.
- changed `prioritisation-map` in the `RPCResult` to `""`
- Directly constructing 2 entry map for getprioritisedtransactions in functional tests
- renamed `txid` to `transactionid` in `RPCResult` to be more consistent with naming elsewhere
- exposed the `modified_fee` field instead of having it be a useless arg
- Created a new test that asserts when `prioritisedtransaction` is called with a fee_delta of 0 it is not added to mempool
ACKs for top commit:
glozow:
reACK 0eebd6fe7d01ddc7f6b7f13a6ed6e705c7aeae4e, only change is the doc suggestion
Tree-SHA512: e99056e37a8b1cfc511d87c83edba7c928b50d2cd6c2fd7c038976779850677ad37fddeb2b983e8bc007ca8567eb21ebb78d7eae9b773657c2b297299993ec05
Diffstat (limited to 'test/lint/lint-format-strings.py')
0 files changed, 0 insertions, 0 deletions