diff options
| author | Wladimir J. van der Laan <laanwj@gmail.com> | 2019-07-03 14:49:07 +0200 |
|---|---|---|
| committer | Wladimir J. van der Laan <laanwj@gmail.com> | 2019-07-03 14:49:40 +0200 |
| commit | 11de669d8b7a1f641ab6fb488feb3134f0d2b1be (patch) | |
| tree | 9cc28b30a0a213c581d60de4bde90506b2ac20d8 /test/fuzz | |
| parent | 9339008a9dce4793a7bb9fd61fc69b274c74b406 (diff) | |
| parent | fab0c820fa4c0c3227eec85c64310a3bf938a149 (diff) | |
Merge #16325: rpc: Clarify that block count means height excl genesis
fab0c820fa4c0c3227eec85c64310a3bf938a149 rpc: Clarify that block count means height excl genesis (MarcoFalke)
Pull request description:
There is a common misconception that the block count returned by the blockchain rpcs includes the genesis block. See for example the discussion in https://github.com/bitcoin/bitcoin/pull/16292#issuecomment-506303256.
However, it really returns the height, which is `0` for the genesis block.
So clarify that and also remove the misleading "longest blockchain" comment.
Finally, fix the wallet test that incorrectly used this rpc.
ACKs for top commit:
instagibbs:
utACK https://github.com/bitcoin/bitcoin/pull/16325/commits/fab0c820fa4c0c3227eec85c64310a3bf938a149
promag:
ACK fab0c82, sorry for the misconception.
Tree-SHA512: 0d087cbb628d3866352bca6420402f392e6a997e579941701a408a7fca355d84645045661f39b022e4479cc07f85a6cddaa9095b6fd9911b245692482420a5e4
Diffstat (limited to 'test/fuzz')
0 files changed, 0 insertions, 0 deletions