diff options
| author | Samuel Dobson <dobsonsa68@gmail.com> | 2020-04-23 13:57:16 +1200 |
|---|---|---|
| committer | Samuel Dobson <dobsonsa68@gmail.com> | 2020-04-23 14:12:35 +1200 |
| commit | e890c15e2cc91487ce023900912646ff56ee97b4 (patch) | |
| tree | 855c295fe7a3dee9d439770f801837e559d20633 /test/functional | |
| parent | 4f802e59a044b208a52c21e6bcc908d38e1d3bd6 (diff) | |
| parent | fa60afc4fb957875bab1c8982d9d9e4999a3814c (diff) | |
| download | bitcoin-e890c15e2cc91487ce023900912646ff56ee97b4.tar.xz | |
Merge #18671: wallet: Add BlockUntilSyncedToCurrentChain to dumpwallet
fa60afc4fb957875bab1c8982d9d9e4999a3814c wallet: Add BlockUntilSyncedToCurrentChain to dumpwallet (MarcoFalke)
Pull request description:
dumpwallet includes the block hash in the output, so this method depends on the chainstate. According to the developer notes https://github.com/bitcoin/bitcoin/blame/e84a5f000493fe39adb2a5f22b43c3848dcd0a4f/doc/developer-notes.md#L1095 it must include a `BlockUntilSyncedToCurrentChain`.
This is a minor fix and does not need backport, I think.
It fixes test failures such as https://travis-ci.org/github/bitcoin/bitcoin/jobs/675487097#L2657 , which can only happen in master because the test was not backported.
ACKs for top commit:
promag:
Code review ACK fa60afc4fb957875bab1c8982d9d9e4999a3814c.
ryanofsky:
Code review ACK fa60afc4fb957875bab1c8982d9d9e4999a3814c
meshcollider:
utACK fa60afc4fb957875bab1c8982d9d9e4999a3814c
Tree-SHA512: 8df70b06b226b2cdf880dec9264adb72d66fd81b09b404fd1665a79e5f5236d26122eebf15df00fe71ee292b5c91b2dc23a0a42b2aa50a8d690604b23832723f
Diffstat (limited to 'test/functional')
0 files changed, 0 insertions, 0 deletions