diff options
| author | fanquake <fanquake@gmail.com> | 2023-08-22 09:52:38 +0100 |
|---|---|---|
| committer | fanquake <fanquake@gmail.com> | 2023-08-22 10:15:37 +0100 |
| commit | c00bc6306163197793d9ff52513fca430c6cae72 (patch) | |
| tree | 5159347c9972bc4264a03b0d782579f1d0cb67af /test/functional | |
| parent | a84dade1f9df747bb440bedb474ea629d2d6ff34 (diff) | |
| parent | 452c094449de00f3640e6e0763366e7603375825 (diff) | |
Merge bitcoin/bitcoin#28288: test: fix 'unknown named parameter' test in `wallet_basic`
452c094449de00f3640e6e0763366e7603375825 test: fix 'unknown named parameter' test in `wallet_basic` (brunoerg)
Pull request description:
This PR removes loop when testing an unknown named parameter. They don't have any effect.
ACKs for top commit:
jonatack:
ACK 452c094449de00f3640e6e0763366e7603375825
theStack:
re-ACK 452c094449de00f3640e6e0763366e7603375825
Tree-SHA512: cf1a37d738bb6fdf9817e7b1d33bc69643dae61e3dbfae5c1e9f26220c55db6f134018dd9a1c65c13869ee58bcb6f3337c5999aabf2614d3126fbc01270705e8
Diffstat (limited to 'test/functional')
| -rwxr-xr-x | test/functional/wallet_basic.py | 6 |
1 files changed, 1 insertions, 5 deletions
diff --git a/test/functional/wallet_basic.py b/test/functional/wallet_basic.py index a4eb6ee29a..01149a0977 100755 --- a/test/functional/wallet_basic.py +++ b/test/functional/wallet_basic.py @@ -310,8 +310,7 @@ class WalletTest(BitcoinTestFramework): node_0_bal += amount assert_equal(self.nodes[0].getbalance(), node_0_bal) - for key in ["totalFee", "feeRate"]: - assert_raises_rpc_error(-8, "Unknown named parameter key", self.nodes[2].sendtoaddress, address=address, amount=1, fee_rate=1, key=1) + assert_raises_rpc_error(-8, "Unknown named parameter feeRate", self.nodes[2].sendtoaddress, address=address, amount=1, fee_rate=1, feeRate=1) # Test setting explicit fee rate just below the minimum. self.log.info("Test sendmany raises 'fee rate too low' if fee_rate of 0.99999999 is passed") @@ -505,9 +504,6 @@ class WalletTest(BitcoinTestFramework): fee = prebalance - postbalance - amount assert_fee_amount(fee, tx_size, Decimal(fee_rate_btc_kvb)) - for key in ["totalFee", "feeRate"]: - assert_raises_rpc_error(-8, "Unknown named parameter key", self.nodes[2].sendtoaddress, address=address, amount=1, fee_rate=1, key=1) - # Test setting explicit fee rate just below the minimum. self.log.info("Test sendtoaddress raises 'fee rate too low' if fee_rate of 0.99999999 is passed") assert_raises_rpc_error(-6, "Fee rate (0.999 sat/vB) is lower than the minimum fee rate setting (1.000 sat/vB)", |