diff options
| author | MacroFake <falke.marco@gmail.com> | 2022-09-09 10:35:00 +0200 |
|---|---|---|
| committer | MacroFake <falke.marco@gmail.com> | 2022-09-09 10:35:10 +0200 |
| commit | dd3ada6ec483befcc2233844ebcde26793299064 (patch) | |
| tree | 7e005163152b7233baf156458fb6de800eb18d30 /test/functional | |
| parent | 013924aa6dc91dd8be93c1eaab6546710ed7fde2 (diff) | |
| parent | 2186608172b0e6c3a9907e06fed27dfd927abd45 (diff) | |
Merge bitcoin/bitcoin#25990: test: apply fixed feerate to avoid variable dynamic fees in wallet_groups.py
2186608172b0e6c3a9907e06fed27dfd927abd45 test: apply fixed feerate to avoid variable dynamic fees (stickies-v)
Pull request description:
Without specifying a feerate, we let the wallet decide on an appropriate feerate, which can be influenced by various factors
such as what's in the mempool. Since wallet_groups.py fails when feerates are unstable, we should use a fixed feerate across all nodes. The assumed feerate was 20 sats/vbyte, so this PR adopts that.
Closes #25940. I'm not 100% sure, but I think the increased tx relay speed introduced by #25865 caused the transactions to more quickly and often enter the other nodes' mempools, affecting their feerate calculation done in [`wallet:GetMinimumFeeRate()`](https://github.com/bitcoin/bitcoin/blob/ea67232cdb80c4bc3f16fcd823f6f811fd8903e1/src/wallet/fees.cpp#L68-L72) and thus deviating slightly from the expected 20 sats/vbyte.
Ran `wallet_groups.py` over 400 times without failure.
ACKs for top commit:
aureleoules:
ACK 2186608172b0e6c3a9907e06fed27dfd927abd45.
glozow:
Approach ACK 2186608172b0e6c3a9907e06fed27dfd927abd45
Tree-SHA512: 0ea467a67747e6f27369ccd0adacfb21cc36ef0ae728fb28b8ea18e409aab5bd3ede559d6cebb82da0b9703c0c8b2709d686feb3ae009ddf525aa253f44d5816
Diffstat (limited to 'test/functional')
| -rwxr-xr-x | test/functional/wallet_groups.py | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/test/functional/wallet_groups.py b/test/functional/wallet_groups.py index 9f0f694a3e..e5e4cf03bf 100755 --- a/test/functional/wallet_groups.py +++ b/test/functional/wallet_groups.py @@ -26,9 +26,10 @@ class WalletGroupTest(BitcoinTestFramework): ["-maxapsfee=0.00002719"], ["-maxapsfee=0.00002720"], ] - # whitelist peers to speed up tx relay / mempool sync + for args in self.extra_args: - args.append("-whitelist=noban@127.0.0.1") + args.append("-whitelist=noban@127.0.0.1") # whitelist peers to speed up tx relay / mempool sync + args.append(f"-paytxfee={20 * 1e3 / 1e8}") # apply feerate of 20 sats/vB across all nodes self.rpc_timeout = 480 |