diff options
| author | Wladimir J. van der Laan <laanwj@gmail.com> | 2017-03-07 09:50:41 +0100 |
|---|---|---|
| committer | MarcoFalke <falke.marco@gmail.com> | 2017-10-04 15:11:24 +0200 |
| commit | a43be5bcdb27a68abe9bb5fec57185a1b6652479 (patch) | |
| tree | 41a6954250a13e353d05f1bcddcc122382a9bcef /test/functional | |
| parent | b6c0209aaf372a21090c0a3eed973022af14ece0 (diff) | |
| download | bitcoin-a43be5bcdb27a68abe9bb5fec57185a1b6652479.tar.xz | |
rpc: Prevent `dumpwallet` from overwriting files
Prevent arbitrary files from being overwritten. There have been reports
that users have overwritten wallet files this way. It may also avoid
other security issues.
Fixes #9934. Adds mention to release notes and adds a test.
Github-Pull: #9937
Rebased-From: 0cd9273fd959c6742574259d026039f7da0309a2
Diffstat (limited to 'test/functional')
| -rwxr-xr-x | test/functional/wallet-dump.py | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/test/functional/wallet-dump.py b/test/functional/wallet-dump.py index 569cc46e6c..016bd95925 100755 --- a/test/functional/wallet-dump.py +++ b/test/functional/wallet-dump.py @@ -7,7 +7,7 @@ import os from test_framework.test_framework import BitcoinTestFramework -from test_framework.util import assert_equal +from test_framework.util import (assert_equal, assert_raises_jsonrpc) def read_dump(file_name, addrs, hd_master_addr_old): @@ -108,5 +108,8 @@ class WalletDumpTest(BitcoinTestFramework): assert_equal(found_addr_chg, 90*2 + 50) # old reserve keys are marked as change now assert_equal(found_addr_rsv, 90*2) + # Overwriting should fail + assert_raises_jsonrpc(-8, "already exists", self.nodes[0].dumpwallet, tmpdir + "/node0/wallet.unencrypted.dump") + if __name__ == '__main__': WalletDumpTest().main () |