aboutsummaryrefslogtreecommitdiff
path: root/test/functional/wallet_upgradewallet.py
diff options
context:
space:
mode:
authorMarcoFalke <falke.marco@gmail.com>2020-04-30 09:36:54 -0400
committerMarcoFalke <falke.marco@gmail.com>2020-04-30 11:45:16 -0400
commitfa359d14c09c6b139dead5da17c5a1c02f68393c (patch)
tree4259dc1fcf467f8fb6bb3d2d1f25f49b613c4e7d /test/functional/wallet_upgradewallet.py
parent00c1a4d9a95eaead64508ee2a7625bdc67e65fa3 (diff)
test: Strip down previous releases boilerplate
Diffstat (limited to 'test/functional/wallet_upgradewallet.py')
-rwxr-xr-xtest/functional/wallet_upgradewallet.py25
1 files changed, 5 insertions, 20 deletions
diff --git a/test/functional/wallet_upgradewallet.py b/test/functional/wallet_upgradewallet.py
index d04bc4ce44..e7e71bf3f6 100755
--- a/test/functional/wallet_upgradewallet.py
+++ b/test/functional/wallet_upgradewallet.py
@@ -12,14 +12,15 @@ contrib/devtools/previous_release.sh -b v0.15.2 v0.16.3
import os
import shutil
-from test_framework.test_framework import BitcoinTestFramework, SkipTest
+from test_framework.test_framework import BitcoinTestFramework
from test_framework.util import (
adjust_bitcoin_conf_for_pre_17,
assert_equal,
assert_greater_than,
- assert_is_hex_string
+ assert_is_hex_string,
)
+
class UpgradeWalletTest(BitcoinTestFramework):
def set_test_params(self):
self.setup_clean_chain = True
@@ -32,32 +33,16 @@ class UpgradeWalletTest(BitcoinTestFramework):
def skip_test_if_missing_module(self):
self.skip_if_no_wallet()
+ self.skip_if_no_previous_releases()
def setup_network(self):
self.setup_nodes()
def setup_nodes(self):
- if os.getenv("TEST_PREVIOUS_RELEASES") == "false":
- raise SkipTest("upgradewallet RPC tests")
-
- releases_path = os.getenv("PREVIOUS_RELEASES_DIR") or os.getcwd() + "/releases"
- if not os.path.isdir(releases_path):
- if os.getenv("TEST_PREVIOUS_RELEASES") == "true":
- raise AssertionError("TEST_PREVIOUS_RELEASES=1 but releases missing: " + releases_path)
- raise SkipTest("This test requires binaries for previous releases")
-
self.add_nodes(self.num_nodes, extra_args=self.extra_args, versions=[
None,
160300,
- 150200
- ], binary=[
- self.options.bitcoind,
- releases_path + "/v0.16.3/bin/bitcoind",
- releases_path + "/v0.15.2/bin/bitcoind",
- ], binary_cli=[
- self.options.bitcoincli,
- releases_path + "/v0.16.3/bin/bitcoin-cli",
- releases_path + "/v0.15.2/bin/bitcoin-cli",
+ 150200,
])
# adapt bitcoin.conf, because older bitcoind's don't recognize config sections
adjust_bitcoin_conf_for_pre_17(self.nodes[1].bitcoinconf)