diff options
| author | MarcoFalke <falke.marco@gmail.com> | 2020-02-29 03:07:36 +0700 |
|---|---|---|
| committer | MarcoFalke <falke.marco@gmail.com> | 2020-02-29 03:07:40 +0700 |
| commit | 9aa8145bc0241c39281e300b4183ca672d4ae2ac (patch) | |
| tree | f5c40e11456e7c46d4bd4e16c162bd3a324ce3db /test/functional/wallet_resendwallettransactions.py | |
| parent | 5ad80bec3f31c0e4bec0bc0b62dff28b32e4b8b5 (diff) | |
| parent | 54be4e71d898de8f14e3269550d56097c023d1cc (diff) | |
| download | bitcoin-9aa8145bc0241c39281e300b4183ca672d4ae2ac.tar.xz | |
Merge #17959: test: check specific reject reasons in feature_csv_activation.py
54be4e71d898de8f14e3269550d56097c023d1cc test: check specific reject reasons in feature_csv_activation.py (Sebastian Falbesoner)
Pull request description:
This is kind of a prequel to #17921: increases the general quality of the functional test `feature_csv_activation.py` by checking for the specific reject reasons whenever the sending of a block fails. To get the reason, we have to limit the script threads to 1 via the parameter `-par=1`, like it is also done in `feature_cltv.py`:
https://github.com/bitcoin/bitcoin/blob/a654626f076a72416a3d354218d7107571d6caaf/test/functional/feature_cltv.py#L57-L61
The commit also fixes a bug that was uncovered with this checks: for the BIP112 version 1 tx tests, txs from `bip112txs_vary_OP_CSV_v1` have been add twice to the list `failed_txs`:
https://github.com/bitcoin/bitcoin/blob/a654626f076a72416a3d354218d7107571d6caaf/test/functional/feature_csv_activation.py#L396-L397
leading also to a block rejection as expected but for the wrong reason. It seems one of those two tx lists was meant to be `bip112txs_vary_OP_CSV_v1` (without the `_9`) and it was a typo.
ACKs for top commit:
MarcoFalke:
ACK 54be4e71d898de8f14e3269550d56097c023d1cc 📶
Tree-SHA512: 9aac11aee3f53f1ae95ddb346a2f268872038f4d118c8dcf81b8201dee869774c9f3c3f1c326e370b8fd4eaf8e0673371689a96d9b1cb91be4286c88824725c3
Diffstat (limited to 'test/functional/wallet_resendwallettransactions.py')
0 files changed, 0 insertions, 0 deletions