diff options
| author | MarcoFalke <falke.marco@gmail.com> | 2018-11-30 10:49:42 -0500 |
|---|---|---|
| committer | MarcoFalke <falke.marco@gmail.com> | 2018-11-30 10:49:49 -0500 |
| commit | 13a7454fbdac2ec13637ff6dbe7a51f2d0439d55 (patch) | |
| tree | 62de81b9004d328f195c409dffbc0aa01de68a28 /test/functional/wallet_keypool.py | |
| parent | 74254fea1ef04fd198cf09e152e71942f4d32d5f (diff) | |
| parent | 0fb2e69815bd5146e601a7fd3585f21a1fdd6f5d (diff) | |
Merge #14380: fix assert crash when specified change output spend size is unknown
0fb2e69815 CreateTransaction: Assume minimum p2sh-p2wpkh spend size for unknown change (Gregory Sanders)
b06483c96a Remove stale comment in CalculateMaximumSignedInputSize (Gregory Sanders)
Pull request description:
This is triggered anytime a fundraw type call(psbt or legacy) is used with a change output address that the wallet doesn't know how to sign for.
This regression was added in 6a34ff5335786615771ca423134a484b04831c4e since BnB coin selection actually cares about this.
The fix is to assume the smallest typical spend, a P2SH-P2WPKH, which is calculated using a "prototype" dummy signature flow. Future work could generalize this infrastructure to get estimated sizes of inputs for a variety of types.
I also removed a comment which I believe is stale and misleading.
Tree-SHA512: c7e2be189e524f81a7aa4454ad9370cefba715e3781f1e462c8bab77e4d27540191419029e3ebda11e3744c0703271e479dcd560d05e4d470048d9633e34da16
Diffstat (limited to 'test/functional/wallet_keypool.py')
0 files changed, 0 insertions, 0 deletions