diff options
| author | glozow <gloriajzhao@gmail.com> | 2023-07-06 10:47:29 +0100 |
|---|---|---|
| committer | glozow <gloriajzhao@gmail.com> | 2023-07-06 10:47:41 +0100 |
| commit | ecf3baffc0b64fe0418b69bcfa5faeb83cff6246 (patch) | |
| tree | ffbaab91a62ecd345720fe750b0f0f6c0ef88d62 /test/functional/wallet_backwards_compatibility.py | |
| parent | bc4f6b13feb29146b7e10e86f93dc7f6fb6937f2 (diff) | |
| parent | 8fbb6e99bfc85a1b9003cae402a7335843a86abd (diff) | |
Merge bitcoin/bitcoin#27869: wallet: Give deprecation warning when loading a legacy wallet
8fbb6e99bfc85a1b9003cae402a7335843a86abd wallet: Give deprecation warning when loading a legacy wallet (Andrew Chow)
Pull request description:
Next step in legacy wallet deprecation.
ACKs for top commit:
S3RK:
reACK 8fbb6e99bfc85a1b9003cae402a7335843a86abd
jonatack:
re-ACK 8fbb6e99bfc85a1b9003cae402a7335843a86abd
Tree-SHA512: 902984b09452926cf199f06e5fb56e4985325cdd5e0dcc829992158488f42d5fbc33e9a30a29303feac24c8315193e8d31712022e2a0503abd6b67169a0027f4
Diffstat (limited to 'test/functional/wallet_backwards_compatibility.py')
| -rwxr-xr-x | test/functional/wallet_backwards_compatibility.py | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/test/functional/wallet_backwards_compatibility.py b/test/functional/wallet_backwards_compatibility.py index 7d88e009c7..49e36b21c5 100755 --- a/test/functional/wallet_backwards_compatibility.py +++ b/test/functional/wallet_backwards_compatibility.py @@ -264,10 +264,11 @@ class BackwardsCompatibilityTest(BitcoinTestFramework): os.path.join(node_master_wallets_dir, "u1_v16") ) load_res = node_master.loadwallet("u1_v16") - # Make sure this wallet opens without warnings. See https://github.com/bitcoin/bitcoin/pull/19054 + # Make sure this wallet opens with only the migration warning. See https://github.com/bitcoin/bitcoin/pull/19054 if int(node_master.getnetworkinfo()["version"]) >= 249900: # loadwallet#warnings (added in v25) -- only present if there is a warning - assert "warnings" not in load_res + # Legacy wallets will have only a deprecation warning + assert_equal(load_res["warnings"], ["Wallet loaded successfully. The legacy wallet type is being deprecated and support for creating and opening legacy wallets will be removed in the future. Legacy wallets can be migrated to a descriptor wallet with migratewallet."]) else: # loadwallet#warning (deprecated in v25) -- always present, but empty string if no warning assert_equal(load_res["warning"], '') |