diff options
| author | MarcoFalke <falke.marco@gmail.com> | 2021-12-06 12:28:20 +0100 |
|---|---|---|
| committer | MarcoFalke <falke.marco@gmail.com> | 2021-12-06 12:28:25 +0100 |
| commit | 32d9f3770add88339fdd125f7671351de506b1af (patch) | |
| tree | 1d852235579dd1bb58d63e087ecda2a98143c530 /test/functional/test_runner.py | |
| parent | 22feb7fee9accf1c9f11b896dbfbbe828a1bd056 (diff) | |
| parent | e4a54af6b851b9f884500087c44f75815d40c559 (diff) | |
| download | bitcoin-32d9f3770add88339fdd125f7671351de506b1af.tar.xz | |
Merge bitcoin/bitcoin#23596: test: fix `wallet_transactiontime_rescan.py --descriptors` and add to test runner
e4a54af6b851b9f884500087c44f75815d40c559 test: add wallet_transactiontime_rescan.py --descriptors to test_runner.py (Sebastian Falbesoner)
b60e02e993ce9fc3520e1ec5e85423dcefb06f2d test: fix test wallet_transactiontime_rescan.py for descriptor wallets (Sebastian Falbesoner)
a905ed1a61da2fc278f4bc9fa523e81604f61a5e test: refactor: use `set_node_times` helper in wallet_transactiontime_rescan.py (Sebastian Falbesoner)
Pull request description:
The functional test wallet_transactiontime_rescan.py currently fails on master branch, if descriptor wallets are used (argument `--descriptors`). This is due to the fact that in this case, the test framework maps the importaddress RPC calls to the importdescriptors RPC (rescan=False -> timestamp='now'), which always rescans blocks of the past 2 hours, based on the current MTP timestamp. In order to avoid importing the last address (wo3), we generate 10 more blocks with advanced time, to ensure that the balance after importing is zero:
https://github.com/bitcoin/bitcoin/blob/681b25e3cd7d084f642693152322ed9a40f33ba0/test/functional/wallet_transactiontime_rescan.py#L125-L134
Calling this test with descriptor wallets is also added to test runner. Fixes #23562.
ACKs for top commit:
Sjors:
tACK e4a54af
brunoerg:
tACK e4a54af6b851b9f884500087c44f75815d40c559
Tree-SHA512: 9fd8e298d48dd7947b1218d61a1a66c1241b3dbb14451b0ec7cd30caa74ee540e7ee5a7bd10d421b9e3b6e549fa5c3e85bd02496436128b433b328118642f600
Diffstat (limited to 'test/functional/test_runner.py')
| -rwxr-xr-x | test/functional/test_runner.py | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/test/functional/test_runner.py b/test/functional/test_runner.py index 35cab8f6ec..24740e3011 100755 --- a/test/functional/test_runner.py +++ b/test/functional/test_runner.py @@ -178,7 +178,8 @@ BASE_SCRIPTS = [ 'rpc_rawtransaction.py --legacy-wallet', 'rpc_rawtransaction.py --descriptors', 'wallet_groups.py --legacy-wallet', - 'wallet_transactiontime_rescan.py', + 'wallet_transactiontime_rescan.py --descriptors', + 'wallet_transactiontime_rescan.py --legacy-wallet', 'p2p_addrv2_relay.py', 'wallet_groups.py --descriptors', 'p2p_compactblocks_hb.py', |