diff options
| author | Wladimir J. van der Laan <laanwj@gmail.com> | 2018-12-13 14:21:09 +0100 |
|---|---|---|
| committer | Wladimir J. van der Laan <laanwj@gmail.com> | 2018-12-13 14:22:31 +0100 |
| commit | 7202ae2e1bb43210de55fbfee6b2c7ec12bc804f (patch) | |
| tree | 19c5ca3ded0abd757b640d095fa3006850ed87b4 /test/functional/test_framework | |
| parent | 57c9556095fd0b86db0bcc1c3ea2d241e86f5c51 (diff) | |
| parent | aaaa8eb1edba2a28916d5da6001d421c1b1b253b (diff) | |
| download | bitcoin-7202ae2e1bb43210de55fbfee6b2c7ec12bc804f.tar.xz | |
Merge #14926: test: consensus: Check that final transactions are valid
aaaa8eb1edba2a28916d5da6001d421c1b1b253b test: consensus: Check that final transactions are valid (MarcoFalke)
fae3617d79deee73dd375dc3ea5f4204a74420c5 test: Correctly deserialize without witness (MarcoFalke)
Pull request description:
There is no check that checks that final transactions are valid, i.e. the consensus rules could be changed (accidentally) with none of the tests failing.
Tree-SHA512: 48f4c24bfcc525ddbc1bfe8c37131953b464823428c1f7a278ba6d98b98827b6b84a8eb2b33396bfb5b8cc4012b7cc1cd771637f405ea20beddae001c22aa290
Diffstat (limited to 'test/functional/test_framework')
| -rwxr-xr-x | test/functional/test_framework/messages.py | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/test/functional/test_framework/messages.py b/test/functional/test_framework/messages.py index c2829bd328..356a45d6d0 100755 --- a/test/functional/test_framework/messages.py +++ b/test/functional/test_framework/messages.py @@ -450,6 +450,8 @@ class CTransaction: if flags != 0: self.wit.vtxinwit = [CTxInWitness() for i in range(len(self.vin))] self.wit.deserialize(f) + else: + self.wit = CTxWitness() self.nLockTime = struct.unpack("<I", f.read(4))[0] self.sha256 = None self.hash = None |