diff options
| author | Wladimir J. van der Laan <laanwj@gmail.com> | 2018-04-08 17:05:44 +0200 |
|---|---|---|
| committer | Wladimir J. van der Laan <laanwj@gmail.com> | 2018-04-08 17:40:28 +0200 |
| commit | 15c3bb4268f3366c26a1ba28d32216f2ff86fe7f (patch) | |
| tree | a0833578c70af5d4ead866d563773c7ac9bd322c /test/functional/test_framework/test_framework.py | |
| parent | 25c56cdbe748ec72c1d101c74602cca6bc82eee6 (diff) | |
| parent | e36a0c08529bccc695ec71a7ec1df89367cc1628 (diff) | |
| download | bitcoin-15c3bb4268f3366c26a1ba28d32216f2ff86fe7f.tar.xz | |
Merge #12904: [qa] Ensure bitcoind processes are cleaned up when tests end
e36a0c0 [qa] Ensure bitcoind processes are cleaned up when tests end (Suhas Daftuar)
Pull request description:
When tests fail (such as due to a bug in the test, race condition, etc), it's possible that we could follow code paths that bypass our normal node shutdown that occurs in `TestNode.stop_node`. Add a destructor to `TestNode` that cleans this up.
Tree-SHA512: 72e04bc21462ebd0cb346fd1fe0540da454acfbad41923a0b06ea2317e9045b68e58f9adb02d8200891aca89a9d03a022eb72282aeb31a3b3afe7c6843a4b450
Diffstat (limited to 'test/functional/test_framework/test_framework.py')
| -rwxr-xr-x | test/functional/test_framework/test_framework.py | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/test/functional/test_framework/test_framework.py b/test/functional/test_framework/test_framework.py index 543643f273..1dbd262063 100755 --- a/test/functional/test_framework/test_framework.py +++ b/test/functional/test_framework/test_framework.py @@ -148,6 +148,8 @@ class BitcoinTestFramework(): if self.nodes: self.stop_nodes() else: + for node in self.nodes: + node.cleanup_on_exit = False self.log.info("Note: bitcoinds were not stopped and may still be running") if not self.options.nocleanup and not self.options.noshutdown and success != TestStatus.FAILED: |