diff options
| author | Hennadii Stepanov <32963518+hebasto@users.noreply.github.com> | 2021-09-29 11:52:38 +0300 |
|---|---|---|
| committer | Hennadii Stepanov <32963518+hebasto@users.noreply.github.com> | 2021-09-29 11:58:15 +0300 |
| commit | ccc4b9125ae4e2d45979137507c63684c373bb92 (patch) | |
| tree | febb57954792f06fbf2d94c169d30f9a1ff71db5 /test/functional/test_framework/script_util.py | |
| parent | 33e31f8df920acd3a4b13aab5bd6a6733480133a (diff) | |
| parent | 4832737c7dcc87afea5e1e88945ec311417aa876 (diff) | |
Merge bitcoin-core/gui#345: Connection Type Translator Comments
4832737c7dcc87afea5e1e88945ec311417aa876 qt: connection type translator comments (Jarol Rodriguez)
Pull request description:
This PR introduces Qt translator comments for `Connection Type` strings in `guiutil.cpp` as well as `rpcconsole.cpp`.
This is an alternate implementation of the idea presented in the last three commits of #289. It is especially inspired by commit 842f4e834dfe5fd2786a5092f78ea28da1b36e4f.
Per [Qt Dev Notes](https://github.com/bitcoin-core/bitcoin-devwiki/wiki/Developer-Notes-for-Qt-Code), it is better to not break up strings when not necessary. This way we preserve the full context for translators.
ACKs for top commit:
jonatack:
Code review re-ACK 4832737c7dcc87afea5e1e88945ec311417aa876 per `git diff 371e2b9 4832737`, changes are translator comment edits since my review yesterday (thank you for updating)
hebasto:
ACK 4832737c7dcc87afea5e1e88945ec311417aa876
Tree-SHA512: 67e1741e10a2e30cde6d50d3293eec89f0b7641b34463865dc6909d2926cdcf33a7d8c1dc8055d2f85906ad2002cdaa594d37b184d16e2f06614b6c5ad00c982
Diffstat (limited to 'test/functional/test_framework/script_util.py')
0 files changed, 0 insertions, 0 deletions