diff options
author | MarcoFalke <falke.marco@gmail.com> | 2019-05-08 10:03:06 -0400 |
---|---|---|
committer | MarcoFalke <falke.marco@gmail.com> | 2019-05-08 10:06:21 -0400 |
commit | fa52eb55c9fe3f7f8517a5804a55edb7f7b3a625 (patch) | |
tree | 5ed0ba914b00a7c2c108626a287bc881d0499604 /test/functional/test_framework/messages.py | |
parent | c459c5f70176928adcee4935813a2dbe7f4dbd51 (diff) |
test: Remove True argument to CBlock::serialize
Unnamed arguments are confusing as to what they mean without looking up
the function signature.
Since segwit is active by default in regtest, and all blocks are
serialized with witness (#15664, c459c5f), remove the argument
`with_witness=True` from all calls to `CBlock::serialize` and
`BlockTransactions::serialize`.
This diff has been created with a script, but is better reviewed without
a scripted diff.
sed -i --regexp-extended -e 's/block(_?[2a-z]*)\.serialize\([a-z_]*=?True/block\1.serialize(/g' $(git grep -l serialize ./test)
Diffstat (limited to 'test/functional/test_framework/messages.py')
-rwxr-xr-x | test/functional/test_framework/messages.py | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/test/functional/test_framework/messages.py b/test/functional/test_framework/messages.py index 954ae3c4df..00190e4cbd 100755 --- a/test/functional/test_framework/messages.py +++ b/test/functional/test_framework/messages.py @@ -1155,7 +1155,7 @@ class msg_generic: class msg_witness_block(msg_block): __slots__ = () def serialize(self): - r = self.block.serialize(with_witness=True) + r = self.block.serialize() return r @@ -1454,5 +1454,5 @@ class msg_witness_blocktxn(msg_blocktxn): def serialize(self): r = b"" - r += self.block_transactions.serialize(with_witness=True) + r += self.block_transactions.serialize() return r |