diff options
| author | MarcoFalke <falke.marco@gmail.com> | 2020-12-14 13:36:55 +0100 |
|---|---|---|
| committer | MarcoFalke <falke.marco@gmail.com> | 2020-12-14 13:37:21 +0100 |
| commit | b103fdcb3bf41a063752605311c80a11ef666596 (patch) | |
| tree | 70c528fbf04c5043d7d7b2784a1a7180c96eb746 /test/functional/rpc_users.py | |
| parent | eec9366f7dd60e522ab339d69a0052a57598829a (diff) | |
| parent | 7fabe0f359ae16ed36ce4ca2c33631d038c21448 (diff) | |
Merge #19763: net: don't try to relay to the address' originator
7fabe0f359ae16ed36ce4ca2c33631d038c21448 net: don't relay to the address' originator (Vasil Dimov)
Pull request description:
For each address to be relayed we "randomly" pick 2 nodes to send the
address to (in `RelayAddress()`). However we do not take into
consideration that it does not make sense to relay the address back to
its originator (`CNode::PushAddress()` will do nothing in that case).
This means that if the originator is among the "randomly" picked nodes,
then we will relay to one node less than intended.
Fix this by skipping the originating node when choosing candidates to
relay to.
ACKs for top commit:
sdaftuar:
ACK 7fabe0f359ae16ed36ce4ca2c33631d038c21448 (this time I looked at the test, and verified the test breaks in expected ways if I break the code).
jnewbery:
utACK 7fabe0f359ae16ed36ce4ca2c33631d038c21448 (only net_processing changes. I haven't reviewed the test changes)
jonatack:
re-ACK 7fabe0f359ae16ed36ce4ca2c33631d038c21448 per `git range-diff b76abae fd897f8 7fabe0f`, change since last review is rebase and more readable Doxygen documentation
Tree-SHA512: c6a9d11c7afc97ab4e8960513f6416648d4a8c0c64b713c145a7482a7b9e54946f81386a3351e3ec0011e5594ba5ccff4d10c6f656bb80680d9f0d0a63366165
Diffstat (limited to 'test/functional/rpc_users.py')
0 files changed, 0 insertions, 0 deletions